[Libreoffice-commits] core.git: accessibility/source basctl/source basic/source canvas/source chart2/source comphelper/source dbaccess/source framework/source include/o3tl include/sfx2 sc/inc sc/source sdext/source sd/source slideshow/source svgio/inc svtools/source sw/inc sw/source xmloff/source

Thorsten Behrens thb at documentfoundation.org
Sat Aug 29 16:26:06 PDT 2015


Daniel Robertson wrote:
> --- a/include/o3tl/cow_wrapper.hxx
> +++ b/include/o3tl/cow_wrapper.hxx
> @@ -199,7 +199,10 @@ int cow_wrapper_client::queryUnmodified() const
>          void release()
>          {
>              if( m_pimpl && !MTPolicy::decrementCount(m_pimpl->m_ref_count) )
> -                boost::checked_delete(m_pimpl), m_pimpl = nullptr;
> +            {
> +                delete m_pimpl;
> +                m_pimpl = nullptr;
> +            }
>          }
>
Hi Stephan, all,

Daniel reduced boost dependencies a bit with the above, nominally w/o
losing functionality.

I find -Werror=delete-incomplete for gcc and -Wdelete-incomplete for
clang - that's supposedly a much more universal way of catching the
issues checked_delete was there for?

What's the best way to enable that in tinderboxes, I'm afraid
gbuild-wide enabling might fail on older compilers?

Cheers,

-- Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20150830/d870f4b5/attachment.sig>


More information about the LibreOffice mailing list