[Bug 96348] Get rid of unnecessary DLLPUBLIC decorations in module-internal include files

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Wed Dec 9 02:06:19 PST 2015


Stephan Bergmann <sbergman at redhat.com> changed:

           What    |Removed                     |Added
                 CC|                            |sbergman at redhat.com

--- Comment #2 from Stephan Bergmann <sbergman at redhat.com> ---
(In reply to Tor Lillqvist from comment #0)
> Don't submit such a change unless you have tested that the code still builds,

...and passes "make check", as some DLLPUBLICs might only be there for test
code to be able to access otherwise internal entities.  (In which case those
uses of DLLPUBLIC should arguably be commented accordingly.)

Also, note that there is different behaviour between GCC (as typically used on
Linux) and Clang (as typically used on Mac OS X, but also on Linux) whether to
treat non-exported RTTI of types with identical identifiers as identical.  This
can e.g. have consequences for uses of dynamic_cast, and can be relevant e.g.
when a class in vcl/inc/ has erroneously been marked VCL_DLLPUBLIC instead of

You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20151209/e3f1b54d/attachment.html>

More information about the LibreOffice mailing list