New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
7 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1346892:  Resource leaks  (VIRTUAL_DTOR)
/vcl/unx/generic/gdi/gcach_xpeer.cxx: 31 in X11GlyphCache::~X11GlyphCache()()


________________________________________________________________________________________________________
*** CID 1346892:  Resource leaks  (VIRTUAL_DTOR)
/vcl/unx/generic/gdi/gcach_xpeer.cxx: 31 in X11GlyphCache::~X11GlyphCache()()
25     #include "unx/saldata.hxx"
26     #include "unx/salgdi.h"
27     
28     #include "gcach_xpeer.hxx"
29     #include "xrender_peer.hxx"
30     
>>>     CID 1346892:  Resource leaks  (VIRTUAL_DTOR)
>>>     Class "X11GlyphCache" has a destructor and a pointer to it is upcast to class "GlyphCache" which doesn't have a virtual destructor.
31     X11GlyphCache::~X11GlyphCache()
32     {
33         if( !ImplGetSVData() )
34             return;
35     
36         //Why do this here, move into dtor/shutdown of display?

** CID 1346891:  Code maintainability issues  (UNUSED_VALUE)
/sw/source/uibase/dbui/dbmgr.cxx: 1049 in SwDBManager::MergeMailFiles(SwWrtShell *, const SwMergeDescriptor &, vcl::Window *)()


________________________________________________________________________________________________________
*** CID 1346891:  Code maintainability issues  (UNUSED_VALUE)
/sw/source/uibase/dbui/dbmgr.cxx: 1049 in SwDBManager::MergeMailFiles(SwWrtShell *, const SwMergeDescriptor &, vcl::Window *)()
1043                         OUString sAddress;
1044                         if( !bEMail && bColumnName )
1045                             GetPathAddress(sPath, sAddress, xColumnProp);
1046     
1047                         // create a new temporary file name - only done once in case of bCreateSingleFile
1048                         if( createTempFile && ( 1 == nDocNo || !bCreateSingleFile ))
>>>     CID 1346891:  Code maintainability issues  (UNUSED_VALUE)
>>>     Assigning value from "this->CreateNewTemp(sPath, sAddress, aTempFile, rMergeDescriptor, pStoreToFilter)" to "bNoError" here, but that stored value is overwritten before it can be used.
1049                             bNoError = CreateNewTemp(sPath, sAddress, aTempFile, rMergeDescriptor, pStoreToFilter);
1050     
1051                         if( !bCancel )
1052                         {
1053                             std::unique_ptr< INetURLObject > aTempFileURL;
1054                             if( createTempFile )


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/libreoffice?tab=overview

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939