Test failing - CppunitTest_cppcanvas_emfplus

[Chris Sherlock]

Hey all, 

It appears that we are exporting an EMF+ file to PNG, then we do a check to see what color a particular pixel is. 

It *looks* like the actual result should actually be 65280 (0x00FF00 or green), but for some reason we are checking if it’s 65024 (0x00FE00 or a slightly lighter shade of green). 

This test is for the bug here:

https://bugs.documentfoundation.org/show_bug.cgi?id=77229

Can anyone shed any light on this? I think the test is wrong, but would like some other eyes on the code. Thanks!

Chris Sherlock

(failing test below)


[ CUT ] sd_import_tests
warn:vcl.window:31765:1:vcl/source/window/window.cxx:3329: ignoring DeploymentException "service not supplied"
warn:sfx.sidebar:31765:1:sfx2/source/sidebar/SidebarController.cxx:764: Cannot create panel: 
/home/chris/repos/libreoffice/cppcanvas/qa/extras/emfplus/emfplus.cxx:89:Test::testFdo77229
equality assertion failed
- Expected: 65024
- Actual  : 65280

emfplus.cxx:89:Assertion
Test name: Test::testFdo77229
equality assertion failed
- Expected: 65024
- Actual  : 65280

Failures !!!
Run: 1   Failure total: 1   Failures: 1   Errors: 0
warn:fwk:31765:1:framework/source/services/desktop.cxx:1017: Desktop disposed before terminating it

Error: a unit test failed, please do one of:

export DEBUGCPPUNIT=TRUE            # for exception catching
export CPPUNITTRACE="gdb --args"    # for interactive debugging on Linux
export VALGRIND=memcheck            # for memory checking

and retry using: make CppunitTest_cppcanvas_emfplus

/home/chris/repos/libreoffice/solenv/gbuild/CppunitTest.mk:81: recipe for target '/home/chris/repos/libreoffice/workdir/CppunitTest/cppcanvas_emfplus.test' failed
make[1]: *** [/home/chris/repos/libreoffice/workdir/CppunitTest/cppcanvas_emfplus.test] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from /home/chris/repos/libreoffice/sc/qa/unit/ucalc.cxx:10:0:
/home/chris/repos/libreoffice/sc/qa/unit/ucalc.hxx: In static member function ‘static void Test::addTestsToSuite(CppUnit::TestSuiteBuilderContextBase&)’:
/home/chris/repos/libreoffice/sc/qa/unit/ucalc.hxx:427:284: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
     CPPUNIT_TEST_SUITE(Test);
                                                                                                                                                                                                                                                                                            ^
Makefile:243: recipe for target 'build' failed
make: *** [build] Error 2