sc/source/core/data/dociter.cxx: really suspicious use of ! in condition

Matteo Casalin matteo.casalin at yahoo.com
Wed Feb 18 02:51:21 PST 2015


Hi all,
    while looking at http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5ab0e3a8b1cb7c06072229e1c4d956eb81fa002 I noticed a really suspicious use of ! on the same line that was modified:

&& ! nMinNextEnd < nRow

Based on the 'n' prefix and the related usage of ! in conditionals on integers, I would say that that should be !(nMinNextEnd < nRow) or nMinNextEnd >= nRow

Sadly I don't have time to propose a patch in gerrit for review. Does anybody have a clue on what should go there, how to test the results and, if needed, patch the code?

Cheers
Matteo


More information about the LibreOffice mailing list