Purpose of method View::GetEmptyPresentationObject()?

Regina Henschel rb.henschel at t-online.de
Sat Jan 3 07:11:23 PST 2015


Hi all,

I'm looking for someone, who can tell me more about method 
View::GetEmptyPresentationObject()[1]. The method is used in 
FuInsertGraphic::DoExecute() with parameter PRESOBJ_GRAPHIC [2] and in 
View::InsertMediaObj() with parameter PRESOBJ_MEDIA [3] and in 
DrawViewShell::FuTable with parameter PRESOBJ_TABLE [4]. But the 
delivered parameter is not considered in all cases in 
GetEmptyPresentationObject().

This method has been introduced with commit "renaissance01: #i107213# 
further layout work, initial support for new layout toolbox control" by 
Christian Lippka at 3.Dec 2009.

I come across the method when investigating on AOO bug #125613 [5]. The 
call with parameter PRESOBJ_GRAPHIC results in an object of kind 
PRESOBJ_OUTLINE. I think, it should be NULL.

I know, it is an AOO problem, but it might be reason for fdo#64301 [6] too.

My question is: Is the implemented behavior of 
GetEmptyPresentationObject() intended, and if yes, why? Or is it a bug?

Kind regards
Regina

[1] http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/sdview5.cxx
[2] http://opengrok.libreoffice.org/xref/core/sd/source/ui/func/fuinsert.cxx
[3] http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/sdview4.cxx
[4] 
http://opengrok.libreoffice.org/xref/core/sd/source/ui/table/tablefunction.cxx
[5] https://issues.apache.org/ooo/show_bug.cgi?id=125613
[6] https://bugs.freedesktop.org/show_bug.cgi?id=64301




More information about the LibreOffice mailing list