New Defects reported by Coverity Scan for LibreOffice

scan-admin at coverity.com scan-admin at coverity.com
Sun Jul 12 07:29:43 PDT 2015


Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

8 new defect(s) introduced to LibreOffice found with Coverity Scan.
8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 8 of 8 defect(s)


** CID 1311655:  Uninitialized members  (UNINIT_CTOR)
/svx/source/sidebar/shadow/ShadowPropertyPanel.cxx: 88 in svx::sidebar::ShadowPropertyPanel::ShadowPropertyPanel(vcl::Window *, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> &, SfxBindings *)()


________________________________________________________________________________________________________
*** CID 1311655:  Uninitialized members  (UNINIT_CTOR)
/svx/source/sidebar/shadow/ShadowPropertyPanel.cxx: 88 in svx::sidebar::ShadowPropertyPanel::ShadowPropertyPanel(vcl::Window *, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> &, SfxBindings *)()
82         get(mpShadowTransSlider,"transparency_slider");
83         get(mpShadowTransMetric,"FIELD_TRANSPARENCY");
84         get(mpFTColor,"color");
85         get(mpLBShadowColor,"LB_SHADOW_COLOR");
86     
87         Initialize();
>>>     CID 1311655:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "nXY" is not initialized in this constructor nor in any functions that it calls.
88     }
89     
90     ShadowPropertyPanel::~ShadowPropertyPanel()
91     {
92         disposeOnce();
93     }

** CID 1311654:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/control/combobox.cxx: 66 in ComboBox::Impl::Impl(ComboBox&)()


________________________________________________________________________________________________________
*** CID 1311654:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/control/combobox.cxx: 66 in ComboBox::Impl::Impl(ComboBox&)()
60         bool                m_isMatchCase         : 1;
61         sal_Int32           m_nMaxWidthChars;
62         Link<>              m_SelectHdl;
63         Link<>              m_DoubleClickHdl;
64         boost::signals2::scoped_connection m_AutocompleteConnection;
65     
>>>     CID 1311654:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_nMaxWidthChars" is not initialized in this constructor nor in any functions that it calls.
66         Impl(ComboBox & rThis) : m_rThis(rThis) {}
67     
68         void ImplInitComboBoxData();
69         void ImplUpdateFloatSelection();
70         ComboBoxBounds calcComboBoxDropDownComponentBounds(
71             const Size &rOutSize, const Size &rBorderOutSize) const;

** CID 1311653:  Uninitialized members  (UNINIT_CTOR)
/include/vcl/printerinfomanager.hxx: 57 in psp::PrinterInfo::PrinterInfo()()


________________________________________________________________________________________________________
*** CID 1311653:  Uninitialized members  (UNINIT_CTOR)
/include/vcl/printerinfomanager.hxx: 57 in psp::PrinterInfo::PrinterInfo()()
51         // but assigned from the outside (currently for "fax","pdf=","autoqueue","external_dialog")
52         OUString             m_aFeatures;
53         bool                 m_bPapersizeFromSetup;
54     
55         PrinterInfo() :
56                 JobData()
>>>     CID 1311653:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_bPapersizeFromSetup" is not initialized in this constructor nor in any functions that it calls.
57         {}
58     };
59     
60     class VCL_DLLPUBLIC PrinterInfoManager
61     {
62     public:

** CID 1311652:  Error handling issues  (UNCAUGHT_EXCEPT)
/sc/source/ui/vba/vbarange.cxx: 2681 in ScVbaRange::Range(const com::sun::star::uno::Any &, const com::sun::star::uno::Any &, bool)()


________________________________________________________________________________________________________
*** CID 1311652:  Error handling issues  (UNCAUGHT_EXCEPT)
/sc/source/ui/vba/vbarange.cxx: 2681 in ScVbaRange::Range(const com::sun::star::uno::Any &, const com::sun::star::uno::Any &, bool)()
2675     uno::Reference< excel::XRange >
2676     ScVbaRange::Range( const uno::Any &Cell1, const uno::Any &Cell2 ) throw (uno::RuntimeException, std::exception)
2677     {
2678         return Range( Cell1, Cell2, false );
2679     }
2680     uno::Reference< excel::XRange >
>>>     CID 1311652:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "std::length_error" is thrown but the throw list "throw(com::sun::star::uno::RuntimeException)" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
2681     ScVbaRange::Range( const uno::Any &Cell1, const uno::Any &Cell2, bool bForceUseInpuRangeTab ) throw (uno::RuntimeException)
2682     
2683     {
2684         uno::Reference< table::XCellRange > xCellRange = mxRange;
2685     
2686         if ( m_Areas->getCount() > 1 )

** CID 1311651:  Error handling issues  (UNCAUGHT_EXCEPT)
/sc/source/ui/vba/vbarange.cxx: 1363 in ScVbaRange::getRangeObjectForName(const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> &, const rtl::OUString &, ScDocShell *, formula::FormulaGrammar::AddressConvention)()


________________________________________________________________________________________________________
*** CID 1311651:  Error handling issues  (UNCAUGHT_EXCEPT)
/sc/source/ui/vba/vbarange.cxx: 1363 in ScVbaRange::getRangeObjectForName(const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> &, const rtl::OUString &, ScDocShell *, formula::FormulaGrammar::AddressConvention)()
1357         return bHasMerged ? util::TriState_INDETERMINATE : util::TriState_NO;
1358     }
1359     
1360     } // namespace
1361     
1362     css::uno::Reference< excel::XRange >
>>>     CID 1311651:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "std::length_error" is thrown but the throw list "throw(com::sun::star::uno::RuntimeException)" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
1363     ScVbaRange::getRangeObjectForName(
1364             const uno::Reference< uno::XComponentContext >& xContext, const OUString& sRangeName,
1365             ScDocShell* pDocSh, formula::FormulaGrammar::AddressConvention eConv ) throw ( uno::RuntimeException )
1366     {
1367         table::CellRangeAddress refAddr;
1368         return getRangeForName( xContext, sRangeName, pDocSh, refAddr, eConv );

** CID 1311650:  Null pointer dereferences  (FORWARD_NULL)
/vcl/source/window/menufloatingwindow.cxx: 1116 in MenuFloatingWindow::KeyInput(const KeyEvent &)()


________________________________________________________________________________________________________
*** CID 1311650:  Null pointer dereferences  (FORWARD_NULL)
/vcl/source/window/menufloatingwindow.cxx: 1116 in MenuFloatingWindow::KeyInput(const KeyEvent &)()
1110                 sal_uInt16 nPos = 0;
1111                 sal_uInt16 nDuplicates = 0;
1112                 MenuItemData* pData = (nCharCode && pMenu) ?
1113                     pMenu->GetItemList()->SearchItem(nCharCode, rKEvent.GetKeyCode(), nPos, nDuplicates, nHighlightedItem) : NULL;
1114                 bool accel = ImplGetSVData()->maNWFData.mbEnableAccel;
1115                 Menu *men = pMenu;
>>>     CID 1311650:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "men" to "IsMenuBar", which dereferences it. (The dereference happens because this is a virtual function call.)
1116                 while (!men->IsMenuBar())
1117                     men = men->pStartedFrom;
1118                 if ( pData && (static_cast<MenuBarWindow*>(men->pWindow.get()))->GetMBWMenuKey () && accel )
1119                 {
1120                     if ( pData->pSubMenu || nDuplicates > 1 )
1121                     {

** CID 1311649:  Incorrect expression  (CONSTANT_EXPRESSION_RESULT)
/usr/include/boost/function/function_template.hpp: 938 in boost::function0<void>::assign_to<comphelper::FlagGuard::FlagGuard(bool &, comphelper::ScopeGuard::exc_handling)::[lambda() (instance 1)]>(T1)()


________________________________________________________________________________________________________
*** CID 1311649:  Incorrect expression  (CONSTANT_EXPRESSION_RESULT)
/usr/include/boost/function/function_template.hpp: 938 in boost::function0<void>::assign_to<comphelper::FlagGuard::FlagGuard(bool &, comphelper::ScopeGuard::exc_handling)::[lambda() (instance 1)]>(T1)()
932           // http://thread.gmane.org/gmane.comp.lib.boost.devel/164902/.
933           static const vtable_type stored_vtable = 
934             { { &manager_type::manage }, &invoker_type::invoke };
935     
936           if (stored_vtable.assign_to(f, functor)) {
937             std::size_t value = reinterpret_cast<std::size_t>(&stored_vtable.base);
>>>     CID 1311649:  Incorrect expression  (CONSTANT_EXPRESSION_RESULT)
>>>     The expression "true /* mpl_::bool_<true>::value */ && true /* mpl_::bool_<true>::value */" does not accomplish anything because it evaluates to either of its identical operands, "true /* mpl_::bool_<true>::value */".
938             if (boost::has_trivial_copy_constructor<Functor>::value &&
939                 boost::has_trivial_destructor<Functor>::value &&
940                 detail::function::function_allows_small_object_optimization<Functor>::value)
941               value |= static_cast<size_t>(0x01);
942             vtable = reinterpret_cast<detail::function::vtable_base *>(value);
943           } else 

** CID 1311648:    (CONSTANT_EXPRESSION_RESULT)
/usr/include/boost/function/function_template.hpp: 938 in boost::function1<svx::sidebar::PopupControl *, svx::sidebar::PopupContainer *>::assign_to<sw::sidebar::PagePropertyPanel::PagePropertyPanel(vcl::Window *, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> &, SfxBindings *)::[lambda(svx::sidebar::PopupContainer *) (instance 3)]>(T1)()
/usr/include/boost/function/function_template.hpp: 938 in boost::function1<svx::sidebar::PopupControl *, svx::sidebar::PopupContainer *>::assign_to<sw::sidebar::PagePropertyPanel::PagePropertyPanel(vcl::Window *, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> &, SfxBindings *)::[lambda(svx::sidebar::PopupContainer *) (instance 4)]>(T1)()
/usr/include/boost/function/function_template.hpp: 938 in boost::function1<svx::sidebar::PopupControl *, svx::sidebar::PopupContainer *>::assign_to<sw::sidebar::PagePropertyPanel::PagePropertyPanel(vcl::Window *, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> &, SfxBindings *)::[lambda(svx::sidebar::PopupContainer *) (instance 1)]>(T1)()
/usr/include/boost/function/function_template.hpp: 938 in boost::function1<svx::sidebar::PopupControl *, svx::sidebar::PopupContainer *>::assign_to<sw::sidebar::PagePropertyPanel::PagePropertyPanel(vcl::Window *, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> &, SfxBindings *)::[lambda(svx::sidebar::PopupContainer *) (instance 2)]>(T1)()


________________________________________________________________________________________________________
*** CID 1311648:    (CONSTANT_EXPRESSION_RESULT)
/usr/include/boost/function/function_template.hpp: 938 in boost::function1<svx::sidebar::PopupControl *, svx::sidebar::PopupContainer *>::assign_to<sw::sidebar::PagePropertyPanel::PagePropertyPanel(vcl::Window *, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> &, SfxBindings *)::[lambda(svx::sidebar::PopupContainer *) (instance 3)]>(T1)()
932           // http://thread.gmane.org/gmane.comp.lib.boost.devel/164902/.
933           static const vtable_type stored_vtable = 
934             { { &manager_type::manage }, &invoker_type::invoke };
935     
936           if (stored_vtable.assign_to(f, functor)) {
937             std::size_t value = reinterpret_cast<std::size_t>(&stored_vtable.base);
>>>     CID 1311648:    (CONSTANT_EXPRESSION_RESULT)
>>>     The expression "true /* mpl_::bool_<true>::value */ && true /* mpl_::bool_<true>::value */" does not accomplish anything because it evaluates to either of its identical operands, "true /* mpl_::bool_<true>::value */".
938             if (boost::has_trivial_copy_constructor<Functor>::value &&
939                 boost::has_trivial_destructor<Functor>::value &&
940                 detail::function::function_allows_small_object_optimization<Functor>::value)
941               value |= static_cast<size_t>(0x01);
942             vtable = reinterpret_cast<detail::function::vtable_base *>(value);
943           } else 
/usr/include/boost/function/function_template.hpp: 938 in boost::function1<svx::sidebar::PopupControl *, svx::sidebar::PopupContainer *>::assign_to<sw::sidebar::PagePropertyPanel::PagePropertyPanel(vcl::Window *, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> &, SfxBindings *)::[lambda(svx::sidebar::PopupContainer *) (instance 4)]>(T1)()
932           // http://thread.gmane.org/gmane.comp.lib.boost.devel/164902/.
933           static const vtable_type stored_vtable = 
934             { { &manager_type::manage }, &invoker_type::invoke };
935     
936           if (stored_vtable.assign_to(f, functor)) {
937             std::size_t value = reinterpret_cast<std::size_t>(&stored_vtable.base);
>>>     CID 1311648:    (CONSTANT_EXPRESSION_RESULT)
>>>     The expression "true /* mpl_::bool_<true>::value */ && true /* mpl_::bool_<true>::value */" does not accomplish anything because it evaluates to either of its identical operands, "true /* mpl_::bool_<true>::value */".
938             if (boost::has_trivial_copy_constructor<Functor>::value &&
939                 boost::has_trivial_destructor<Functor>::value &&
940                 detail::function::function_allows_small_object_optimization<Functor>::value)
941               value |= static_cast<size_t>(0x01);
942             vtable = reinterpret_cast<detail::function::vtable_base *>(value);
943           } else 
/usr/include/boost/function/function_template.hpp: 938 in boost::function1<svx::sidebar::PopupControl *, svx::sidebar::PopupContainer *>::assign_to<sw::sidebar::PagePropertyPanel::PagePropertyPanel(vcl::Window *, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> &, SfxBindings *)::[lambda(svx::sidebar::PopupContainer *) (instance 1)]>(T1)()
932           // http://thread.gmane.org/gmane.comp.lib.boost.devel/164902/.
933           static const vtable_type stored_vtable = 
934             { { &manager_type::manage }, &invoker_type::invoke };
935     
936           if (stored_vtable.assign_to(f, functor)) {
937             std::size_t value = reinterpret_cast<std::size_t>(&stored_vtable.base);
>>>     CID 1311648:    (CONSTANT_EXPRESSION_RESULT)
>>>     The expression "true /* mpl_::bool_<true>::value */ && true /* mpl_::bool_<true>::value */" does not accomplish anything because it evaluates to either of its identical operands, "true /* mpl_::bool_<true>::value */".
938             if (boost::has_trivial_copy_constructor<Functor>::value &&
939                 boost::has_trivial_destructor<Functor>::value &&
940                 detail::function::function_allows_small_object_optimization<Functor>::value)
941               value |= static_cast<size_t>(0x01);
942             vtable = reinterpret_cast<detail::function::vtable_base *>(value);
943           } else 
/usr/include/boost/function/function_template.hpp: 938 in boost::function1<svx::sidebar::PopupControl *, svx::sidebar::PopupContainer *>::assign_to<sw::sidebar::PagePropertyPanel::PagePropertyPanel(vcl::Window *, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> &, SfxBindings *)::[lambda(svx::sidebar::PopupContainer *) (instance 2)]>(T1)()
932           // http://thread.gmane.org/gmane.comp.lib.boost.devel/164902/.
933           static const vtable_type stored_vtable = 
934             { { &manager_type::manage }, &invoker_type::invoke };
935     
936           if (stored_vtable.assign_to(f, functor)) {
937             std::size_t value = reinterpret_cast<std::size_t>(&stored_vtable.base);
>>>     CID 1311648:    (CONSTANT_EXPRESSION_RESULT)
>>>     The expression "true /* mpl_::bool_<true>::value */ && true /* mpl_::bool_<true>::value */" does not accomplish anything because it evaluates to either of its identical operands, "true /* mpl_::bool_<true>::value */".
938             if (boost::has_trivial_copy_constructor<Functor>::value &&
939                 boost::has_trivial_destructor<Functor>::value &&
940                 detail::function::function_allows_small_object_optimization<Functor>::value)
941               value |= static_cast<size_t>(0x01);
942             vtable = reinterpret_cast<detail::function::vtable_base *>(value);
943           } else 


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/211?tab=overview

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939



More information about the LibreOffice mailing list