Gerrit: Reliability and fidelity of verification results

[Norbert Thiebaud]

On Tue, Jul 21, 2015 at 1:54 AM, David Ostrovsky <d.ostrovsky at gmx.de> wrote:
> On Mon, 2015-07-13 at 16:51 -0500, Norbert Thiebaud wrote:
>> On Mon, Jul 13, 2015 at 1:51 PM, David Ostrovsky <d.ostrovsky at gmx.de> wrote:
>> >> And your patch 8 would have failed the same way on tb58/tb59/tb60
>> >
> [...]
>
>> The release builder have the so-called 'stale' tool chain.
>> Just like in real-life and like other platform there is a diversity of
>> platform and we usually do not drop
>> support for 'older' platform unless there is an imperative motivation.
>>
>
> I have another discrepancy with verification: [1]. This time tinderbox
> TB63 compiler version is ahead of mine: [2]
>
> TB63: GCC 4.8.3
> Mine: GCC 4.8.1
>
> On patch set 8 of this change, it's issuing -Werror=return-type: [3]
> even though the last statement is assert(false);

The last statement is (void) (which is what assert resolve to in non
debug build...
hence the -Werror=return-type
The run you pointed too was not a debug one:
...
export ENABLE_DEBUG=
...