Throw exceptions disabled temporarily disabled since 2002! (transactionManager.cxx)

[julien2412]

Hello,

Giving a try to https://bugs.documentfoundation.org/show_bug.cgi?id=91988, I
haven't reproduced the crash but had some warn logs.
Looking at the source, I read this:
    256                                         // Help programmer to find
out, why this exception is thrown!
    257                                         SAL_WARN( "fwk",
"TransactionManager...: Owner instance not correctly initialized yet. Call
was rejected! Normally it's an algorithm error ... wrong use of class!" );
    258                                         //ATTENTION: temp. disabled
- till all bad code positions are detected and changed! */
    259                                         // throw
css::uno::RuntimeException( "TransactionManager...\nOwner instance not right
initialized yet. Call was rejected! Normally it's an algorithm error ...
wrong usin of class!\n", css::uno::Reference< css::uno::XInterface >() );

The funny thing is:
julien at julienPC:~/compile-libreoffice/libreoffice$ git log --follow -S
'ATTENTION: temp. disabled'
framework/source/fwi/threadhelp/transactionmanager.cxx
commit 3642f95267df77a383e44cde754e2724e0a70733
Author: Andreas Schlüns <as at openoffice.org>
Date:   Thu May 2 10:41:31 2002 +0000

    #99021# fix static inline problem by outlining

2002!!?

There are other "throw" instructions disabled in this part, see
http://opengrok.libreoffice.org/xref/core/framework/source/fwi/threadhelp/transactionmanager.cxx#250

Should we enable them to get crashes and retrieve bugs early?

Julien



--
View this message in context: http://nabble.documentfoundation.org/Throw-exceptions-disabled-temporarily-disabled-since-2002-transactionManager-cxx-tp4151175.html
Sent from the Dev mailing list archive at Nabble.com.