New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1307698:  Uninitialized members  (UNINIT_CTOR)
/reportdesign/source/ui/dlg/dlgpage.cxx: 72 in rptui::ORptPageDialog::ORptPageDialog(vcl::Window *, const SfxItemSet *, const rtl::OUString &)()


________________________________________________________________________________________________________
*** CID 1307698:  Uninitialized members  (UNINIT_CTOR)
/reportdesign/source/ui/dlg/dlgpage.cxx: 72 in rptui::ORptPageDialog::ORptPageDialog(vcl::Window *, const SfxItemSet *, const rtl::OUString &)()
66         else
67             OSL_FAIL("Unknown page id");
68     
69         SvtCJKOptions aCJKOptions;
70         if ( !aCJKOptions.IsDoubleLinesEnabled() )
71             RemoveTabPage("asianlayout");
>>>     CID 1307698:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_nCharBgdId" is not initialized in this constructor nor in any functions that it calls.
72     }
73     
74     void ORptPageDialog::PageCreated( sal_uInt16 nId, SfxTabPage &rPage )
75     {
76         SfxAllItemSet aSet(*(GetInputSetImpl()->GetPool()));
77         if (nId == m_nCharBgdId)

** CID 1307697:  Null pointer dereferences  (NULL_RETURNS)


________________________________________________________________________________________________________
*** CID 1307697:  Null pointer dereferences  (NULL_RETURNS)
/cui/source/tabpages/backgrnd.cxx: 715 in SvxBackgroundTabPage::FillItemSet(SfxItemSet *)()
709                     const bool          bWasLink = (NULL != rOldItem.GetGraphicLink() );
710     
711     
712                     if ( !bIsLink && !bIsGraphicValid )
713                         bIsGraphicValid = LoadLinkedGraphic_Impl();
714     
>>>     CID 1307697:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a pointer that might be null "rOldItem->GetGraphic(rtl::OUString())" when calling "GetBitmap".
715                     if (  eNewPos != eOldPos
716                         || bIsLink != bWasLink
717                         || ( bWasLink  && rOldItem.GetGraphicLink()
718                                            != aBgdGraphicPath )
719                         || ( !bWasLink && rOldItem.GetGraphic()->GetBitmap()
720                                            != aBgdGraphic.GetBitmap() )

** CID 1307696:  Error handling issues  (CHECKED_RETURN)
/framework/source/uifactory/menubarfactory.cxx: 127 in framework::MenuBarFactory::CreateUIElement(const rtl::OUString &, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> &, const char *, const rtl::OUString &, const com::sun::star::uno::Reference<com::sun::star::ui::XUIElement> &, const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> &)()


________________________________________________________________________________________________________
*** CID 1307696:  Error handling issues  (CHECKED_RETURN)
/framework/source/uifactory/menubarfactory.cxx: 127 in framework::MenuBarFactory::CreateUIElement(const rtl::OUString &, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> &, const char *, const rtl::OUString &, const com::sun::star::uno::Reference<com::sun::star::ui::XUIElement> &, const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> &)()
121                 OUString aModuleIdentifier = xModuleManager->identify( Reference<XInterface>( xFrame, UNO_QUERY ) );
122                 if ( !aModuleIdentifier.isEmpty() )
123                 {
124                     Reference< XModuleUIConfigurationManagerSupplier > xModuleCfgSupplier =
125                         theModuleUIConfigurationManagerSupplier::get( _rxContext );
126                     xCfgMgr = xModuleCfgSupplier->getUIConfigurationManager( aModuleIdentifier );
>>>     CID 1307696:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "hasSettings" without checking return value (as is done elsewhere 16 out of 17 times).
127                     xCfgMgr->hasSettings( aResourceURL );
128                 }
129             }
130         }
131     
132         PropertyValue aPropValue;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/211?tab=overview

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939 .