tdf#89872, tdf#88547 use of date arrays as function arguments

Winfried Donkers W.Donkers at dci-electronics.nl
Thu Mar 12 05:30:27 PDT 2015


Hi Eike,

> I want to fix 88547 in a way that doesn't break the use of
> GetNumberSequenceArray() as it did with my original patch, but I'm not
> sure which way to go.
> 
> Currently I think a proper solution would be to check whether we have a
> real non-empty string before we convert it to numeric and push an error
> when conversion to numeric fails; i.e. expand on my original patch of
> GetNumberSequenceArray().
> 
> Given that you know much more of this function and its purpose and history
> that I do (or can find out from git), I would like to hear your
> opinion/suggestion before I start coding.

I think I found a simple and sufficiently robust solution (see https://gerrit.libreoffice.org/14839), so please disregard my question above ;-)

Winfried


More information about the LibreOffice mailing list