some notes on SwClient and SwModify

Stephan Bergmann sbergman at
Mon Mar 23 03:14:55 PDT 2015

On 03/23/2015 09:54 AM, Miklos Vajna wrote:
> I'm not sure why loplugin:cstylecast did not catch these earlier

Because it only warns about a select subset of C-style casts, not 
including "CK_NoOp - A conversion which does not affect the type other 
than (possibly) adding qualifiers."  Working to improve that.

> /home/vmiklos/git/libreoffice/master-clang/sw/source/core/doc/docfmt.cxx:657:26: error: c-style cast, type=5, from='const sw::WriterListener *', to='SwClient *', recommendedFix=static_cast [loplugin:cstylecast]
>      while( 0 != ( pDep = (SwClient*)aCallMod.GetDepends()) )
>                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.

Already reverted that commit with 
before seeing this mail thread.

More information about the LibreOffice mailing list