New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1292224:  Control flow issues  (DEADCODE)
/vcl/source/window/btndlg.cxx: 308 in ButtonDialog::AddButton(StandardButtonType, unsigned short, unsigned short, long)()


________________________________________________________________________________________________________
*** CID 1292224:  Control flow issues  (DEADCODE)
/vcl/source/window/btndlg.cxx: 308 in ButtonDialog::AddButton(StandardButtonType, unsigned short, unsigned short, long)()
302             nBtnFlags |= BUTTONDIALOG_HELPBUTTON;
303         else if ( (eType == StandardButtonType::Cancel) || (eType == StandardButtonType::Close) )
304             nBtnFlags |= BUTTONDIALOG_CANCELBUTTON;
305         pItem->mpPushButton = ImplCreatePushButton( nBtnFlags );
306     
307         // Standard-Buttons have the right text already
>>>     CID 1292224:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "pItem->mpPushButton->GetType() == 328" inside this statement: "if (!(eType == StandardButt...".
308         if ( !((eType == StandardButtonType::OK)     && (pItem->mpPushButton->GetType() == WINDOW_OKBUTTON)) ||
309              !((eType == StandardButtonType::Cancel) && (pItem->mpPushButton->GetType() == WINDOW_CANCELBUTTON)) ||
310              !((eType == StandardButtonType::Help)   && (pItem->mpPushButton->GetType() == WINDOW_HELPBUTTON)) )
311         {
312             pItem->mpPushButton->SetText( Button::GetStandardText( eType ) );
313         }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/211?tab=overview

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939 .