unused code in Calc source?

Eike Rathke erack at redhat.com
Mon May 4 05:57:20 PDT 2015


Hi Winfried,

On Friday, 2015-05-01 13:04:02 +0200, Winfried Donkers wrote:

> In sc/inc/compiler.hxx, struct AddInMap a member bMapDupToInternal is defined.
> As far as I can see, it is not really used in the code.

Indeed, it is unused, I don't actually recall when and how it was
exactly used.

> That is, in sc/source/core/tool/odffmap.cxx it gets a value, but that seems unused.
> The only use I can find, is in a comment in sc/source/filter/excel/xlformula.cxx.
> Is it useful to keep this member, or can it be removed (with relevant comments in both odffmap.cxx and xlformula.cxx)?

I think you can remove it.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20150504/2c561d30/attachment.sig>


More information about the LibreOffice mailing list