four changes of suspicious code (connectivity, sc, sw, editeng)

Miklos Vajna vmiklos at collabora.co.uk
Fri May 8 07:58:23 PDT 2015


Hi Stephan,

On Fri, May 08, 2015 at 10:23:37AM +0200, Stephan Bergmann <sbergman at redhat.com> wrote:
> >diff --git a/sw/source/core/doc/DocumentStylePoolManager.cxx b/sw/source/core/doc/DocumentStylePoolManager.cxx
> >index 3276b9f4..8d4fe0e 100644
> >--- a/sw/source/core/doc/DocumentStylePoolManager.cxx
> >+++ b/sw/source/core/doc/DocumentStylePoolManager.cxx
> >@@ -1318,7 +1318,7 @@ SwFmt* DocumentStylePoolManager::GetFmtFromPool( sal_uInt16 nId )
> >             aSet.Put( SwFmtAnchor( FLY_AT_PAGE ));
> >             aSet.Put( SwFmtHoriOrient( 0, text::HoriOrientation::CENTER, text::RelOrientation::FRAME ));
> >             aSet.Put( SwFmtVertOrient( 0, text::VertOrientation::CENTER, text::RelOrientation::FRAME ));
> >-            aSet.Put( SvxOpaqueItem( sal_False ));
> >+            aSet.Put( SvxOpaqueItem( RES_OPAQUE, false ));

That's correct. The authorative source about which pool item should have
what which id in case of sw is sw/source/core/bastyp/init.cxx AFAIK, and
that has:

aAttrTab[ RES_OPAQUE- POOLATTR_BEGIN ] =                new SvxOpaqueItem( RES_OPAQUE );

Regards,

Miklos
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20150508/178e72cd/attachment.sig>


More information about the LibreOffice mailing list