New Defects reported by Coverity Scan for LibreOffice
scan-admin at coverity.com
scan-admin at coverity.com
Sat May 9 04:24:16 PDT 2015
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.
6 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)
** CID 1297236: Uninitialized members (UNINIT_CTOR)
/framework/source/helper/statusindicator.cxx: 28 in framework::StatusIndicator::StatusIndicator(framework::StatusIndicatorFactory *)()
________________________________________________________________________________________________________
*** CID 1297236: Uninitialized members (UNINIT_CTOR)
/framework/source/helper/statusindicator.cxx: 28 in framework::StatusIndicator::StatusIndicator(framework::StatusIndicatorFactory *)()
22
23 namespace framework{
24
25 StatusIndicator::StatusIndicator(StatusIndicatorFactory* pFactory)
26 : m_xFactory (pFactory)
27 {
>>> CID 1297236: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_nRange" is not initialized in this constructor nor in any functions that it calls.
28 }
29
30 StatusIndicator::~StatusIndicator()
31 {
32 }
33
** CID 1297235: Error handling issues (UNCAUGHT_EXCEPT)
/sal/cppunittester/cppunittester.cxx: 297 in main()
________________________________________________________________________________________________________
*** CID 1297235: Error handling issues (UNCAUGHT_EXCEPT)
/sal/cppunittester/cppunittester.cxx: 297 in main()
291 return run();
292 }
293 };
294
295 }
296
>>> CID 1297235: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::bad_function_call> >" is thrown and never caught.
297 SAL_IMPLEMENT_MAIN() {
298 #ifdef WNT
299 //Disable Dr-Watson in order to crash simply without popup dialogs under
300 //windows
301 DWORD dwMode = SetErrorMode(SEM_NOGPFAULTERRORBOX);
302 SetErrorMode(SEM_NOGPFAULTERRORBOX|dwMode);
** CID 1297234: Error handling issues (UNCAUGHT_EXCEPT)
/reportdesign/source/ui/dlg/GroupsSorting.cxx: 1236 in rptui::OGroupsSortingDialog::_propertyChanged(const com::sun::star::beans::PropertyChangeEvent &)()
________________________________________________________________________________________________________
*** CID 1297234: Error handling issues (UNCAUGHT_EXCEPT)
/reportdesign/source/ui/dlg/GroupsSorting.cxx: 1236 in rptui::OGroupsSortingDialog::_propertyChanged(const com::sun::star::beans::PropertyChangeEvent &)()
1230
1231 void OGroupsSortingDialog::showHelpText(sal_uInt16 _nResId)
1232 {
1233 m_pHelpWindow->SetText(OUString(ModuleRes(_nResId)));
1234 }
1235
>>> CID 1297234: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "boost::bad_pointer" is thrown but the throw list "throw(com::sun::star::uno::RuntimeException)" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
1236 void OGroupsSortingDialog::_propertyChanged(const beans::PropertyChangeEvent& _rEvent) throw( uno::RuntimeException)
1237 {
1238 uno::Reference< report::XGroup > xGroup(_rEvent.Source,uno::UNO_QUERY);
1239 if ( xGroup.is() )
1240 displayGroup(xGroup);
1241 else
** CID 1297233: Null pointer dereferences (FORWARD_NULL)
/sfx2/source/dialog/dockwin.cxx: 1245 in SfxDockingWindow::FillInfo(SfxChildWinInfo &) const()
________________________________________________________________________________________________________
*** CID 1297233: Null pointer dereferences (FORWARD_NULL)
/sfx2/source/dialog/dockwin.cxx: 1245 in SfxDockingWindow::FillInfo(SfxChildWinInfo &) const()
1239 */
1240
1241 {
1242 if ( !pMgr )
1243 return;
1244
>>> CID 1297233: Null pointer dereferences (FORWARD_NULL)
>>> Comparing "this->pImp" to null implies that "this->pImp" might be null.
1245 if ( GetFloatingWindow() && pImp && pImp->bConstructed )
1246 pImp->aWinState = GetFloatingWindow()->GetWindowState();
1247
1248 rInfo.aWinState = pImp->aWinState;
1249 rInfo.aExtraString = "AL:(";
1250 rInfo.aExtraString += OUString::number((sal_uInt16) GetAlignment());
** CID 1297232: Incorrect expression (DIVIDE_BY_ZERO)
/sw/source/core/draw/dflyobj.cxx: 775 in SwVirtFlyDrawObj::NbcCrop(const Point &, const Fraction &, const Fraction &)()
________________________________________________________________________________________________________
*** CID 1297232: Incorrect expression (DIVIDE_BY_ZERO)
/sw/source/core/draw/dflyobj.cxx: 775 in SwVirtFlyDrawObj::NbcCrop(const Point &, const Fraction &, const Fraction &)()
769 convertTwipToMm100(aCrop.GetLeft()),
770 convertTwipToMm100(aCrop.GetTop()),
771 convertTwipToMm100(aCrop.GetRight()),
772 convertTwipToMm100(aCrop.GetBottom()) );
773
774 // Compute delta to apply
>>> CID 1297232: Incorrect expression (DIVIDE_BY_ZERO)
>>> In expression "(aGraphicSize.Width() - aCropRectangle.Left() - aCropRectangle.Right()) / (double)aOldRect.GetWidth()", division by expression "aOldRect.GetWidth()" which may be zero has undefined behavior.
775 double fScaleX = ( aGraphicSize.Width() - aCropRectangle.Left() - aCropRectangle.Right() ) / (double)aOldRect.GetWidth();
776 double fScaleY = ( aGraphicSize.Height() - aCropRectangle.Top() - aCropRectangle.Bottom() ) / (double)aOldRect.GetHeight();
777
778 sal_Int32 nDiffLeft = aNewRect.Left() - aOldRect.Left();
779 sal_Int32 nDiffTop = aNewRect.Top() - aOldRect.Top();
780 sal_Int32 nDiffRight = aNewRect.Right() - aOldRect.Right();
** CID 1297231: Incorrect expression (DIVIDE_BY_ZERO)
/sw/source/core/draw/dflyobj.cxx: 776 in SwVirtFlyDrawObj::NbcCrop(const Point &, const Fraction &, const Fraction &)()
________________________________________________________________________________________________________
*** CID 1297231: Incorrect expression (DIVIDE_BY_ZERO)
/sw/source/core/draw/dflyobj.cxx: 776 in SwVirtFlyDrawObj::NbcCrop(const Point &, const Fraction &, const Fraction &)()
770 convertTwipToMm100(aCrop.GetTop()),
771 convertTwipToMm100(aCrop.GetRight()),
772 convertTwipToMm100(aCrop.GetBottom()) );
773
774 // Compute delta to apply
775 double fScaleX = ( aGraphicSize.Width() - aCropRectangle.Left() - aCropRectangle.Right() ) / (double)aOldRect.GetWidth();
>>> CID 1297231: Incorrect expression (DIVIDE_BY_ZERO)
>>> In expression "(aGraphicSize.Height() - aCropRectangle.Top() - aCropRectangle.Bottom()) / (double)aOldRect.GetHeight()", division by expression "aOldRect.GetHeight()" which may be zero has undefined behavior.
776 double fScaleY = ( aGraphicSize.Height() - aCropRectangle.Top() - aCropRectangle.Bottom() ) / (double)aOldRect.GetHeight();
777
778 sal_Int32 nDiffLeft = aNewRect.Left() - aOldRect.Left();
779 sal_Int32 nDiffTop = aNewRect.Top() - aOldRect.Top();
780 sal_Int32 nDiffRight = aNewRect.Right() - aOldRect.Right();
781 sal_Int32 nDiffBottom = aNewRect.Bottom() - aOldRect.Bottom();
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/211?tab=overview
To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939 .
More information about the LibreOffice
mailing list