Unconditionally include gb_DEBUG_CFLAGS in MSVC bridge_noopt_objects?

David Ostrovsky d.ostrovsky at gmx.de
Mon Nov 2 12:14:44 PST 2015

On Mon Nov 2 08:18:07 PST 2015, Stephan Bergmann wrote:

> Given gb_DEBUG_CFLAGS is always set to the relevant "emit debuginfo"
> flags (/Zi, possibly plus /FS, on MSVC), independently of any
> --enable-dbgutil/-debug/-symbols configuration:  Was the below commit
> really intended to be that way?  Or did it rather want to add those 
> "emit debuginfo" flags *when doing (any sort of) a debug build* only?
>> -       , $(gb_COMPILERNOOPTFLAGS) $(gb_LinkTarget_EXCEPTIONFLAGS)))
>> +       , $(gb_COMPILERNOOPTFLAGS) $(if $(filter MSC,$(COM)),
$(gb_DEBUG_CFLAGS)) $(gb_LinkTarget_EXCEPTIONFLAGS))) \

Should be fixed in [1]. Thanks for reporting.

* [1] https://gerrit.libreoffice.org/19744

More information about the LibreOffice mailing list