[Libreoffice-commits] core.git: editeng: Eliminate unecessary padding in classes

Bjoern Michaelsen bjoern.michaelsen at canonical.com
Wed Nov 4 05:25:59 PST 2015


Hi,

On Wed, Nov 04, 2015 at 07:46:00AM -0500, Ashod Nakashian wrote:
> FWIW, I'd make most classes (esp. heavily used but not heavily
> instantiated) to be human-intuitive first, while, for those that can
> benefit, order members by size (largest first) and bitfields for flags.
> 
> In any case, optimizations like these should be documented, otherwise it's
> not obvious what's intentional and what's accidental.

Yes, this! On the human-intuitive part: If the history of this codebase is
teaching us anything, its that microoptimizations dont age too well and tend to
create cumulating stumbling blocks for high-level algorithmic improvements.

Best,

Bjoern


More information about the LibreOffice mailing list