New Defects reported by Coverity Scan for LibreOffice
scan-admin at coverity.com
scan-admin at coverity.com
Wed Nov 25 06:32:38 PST 2015
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.
10 new defect(s) introduced to LibreOffice found with Coverity Scan.
22 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 10 of 10 defect(s)
** CID 1340232: Error handling issues (UNCAUGHT_EXCEPT)
/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx: 1278 in main()
________________________________________________________________________________________________________
*** CID 1340232: Error handling issues (UNCAUGHT_EXCEPT)
/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx: 1278 in main()
1272 g_signal_connect(pDocView, "size-changed", G_CALLBACK(signalSize), NULL);
1273 g_signal_connect(pDocView, "hyperlink-clicked", G_CALLBACK(signalHyperlink), NULL);
1274 g_signal_connect(pDocView, "cursor-changed", G_CALLBACK(cursorChanged), NULL);
1275 g_signal_connect(pDocView, "formula-changed", G_CALLBACK(formulaChanged), NULL);
1276 }
1277
>>> CID 1340232: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::property_tree::ptree_bad_data> >" is thrown and never caught.
1278 int main( int argc, char* argv[] )
1279 {
1280 if( argc < 3 ||
1281 ( argc > 1 && ( !strcmp( argv[1], "--help" ) || !strcmp( argv[1], "-h" ) ) ) )
1282 return help();
1283
** CID 1340231: Error handling issues (UNCAUGHT_EXCEPT)
/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx: 1278 in main()
________________________________________________________________________________________________________
*** CID 1340231: Error handling issues (UNCAUGHT_EXCEPT)
/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx: 1278 in main()
1272 g_signal_connect(pDocView, "size-changed", G_CALLBACK(signalSize), NULL);
1273 g_signal_connect(pDocView, "hyperlink-clicked", G_CALLBACK(signalHyperlink), NULL);
1274 g_signal_connect(pDocView, "cursor-changed", G_CALLBACK(cursorChanged), NULL);
1275 g_signal_connect(pDocView, "formula-changed", G_CALLBACK(formulaChanged), NULL);
1276 }
1277
>>> CID 1340231: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::property_tree::json_parser::json_parser_error> >" is thrown and never caught.
1278 int main( int argc, char* argv[] )
1279 {
1280 if( argc < 3 ||
1281 ( argc > 1 && ( !strcmp( argv[1], "--help" ) || !strcmp( argv[1], "-h" ) ) ) )
1282 return help();
1283
** CID 1340230: Null pointer dereferences (REVERSE_INULL)
/jurt/com/sun/star/uno/AnyConverter.java: 624 in com.sun.star.uno.AnyConverter.convertSimple(com.sun.star.uno.TypeClass, com.sun.star.uno.Type, java.lang.Object)()
________________________________________________________________________________________________________
*** CID 1340230: Null pointer dereferences (REVERSE_INULL)
/jurt/com/sun/star/uno/AnyConverter.java: 624 in com.sun.star.uno.AnyConverter.convertSimple(com.sun.star.uno.TypeClass, com.sun.star.uno.Type, java.lang.Object)()
618 case TypeClass.DOUBLE_value:
619 return object;
620 }
621 break;
622 case TypeClass.ENUM_value:
623 if (tc == TypeClass.ENUM_value &&
>>> CID 1340230: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "destTClass" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
624 (null == destTClass || destType.equals( type ) /* optional destType */))
625 {
626 return object;
627 }
628 break;
629 case TypeClass.STRING_value:
** CID 1340229: (RESOURCE_LEAK)
/sw/source/uibase/app/docsh2.cxx: 1583 in SwFindDocShell(tools::SvRef<SfxObjectShell> &, SfxObjectShellLock &, const rtl::OUString &, const rtl::OUString &, const rtl::OUString &, short, SwDocShell *)()
/sw/source/uibase/app/docsh2.cxx: 1583 in SwFindDocShell(tools::SvRef<SfxObjectShell> &, SfxObjectShellLock &, const rtl::OUString &, const rtl::OUString &, const rtl::OUString &, short, SwDocShell *)()
/sw/source/uibase/app/docsh2.cxx: 1583 in SwFindDocShell(tools::SvRef<SfxObjectShell> &, SfxObjectShellLock &, const rtl::OUString &, const rtl::OUString &, const rtl::OUString &, short, SwDocShell *)()
/sw/source/uibase/app/docsh2.cxx: 1583 in SwFindDocShell(tools::SvRef<SfxObjectShell> &, SfxObjectShellLock &, const rtl::OUString &, const rtl::OUString &, const rtl::OUString &, short, SwDocShell *)()
________________________________________________________________________________________________________
*** CID 1340229: (RESOURCE_LEAK)
/sw/source/uibase/app/docsh2.cxx: 1583 in SwFindDocShell(tools::SvRef<SfxObjectShell> &, SfxObjectShellLock &, const rtl::OUString &, const rtl::OUString &, const rtl::OUString &, short, SwDocShell *)()
1577 }
1578 }
1579
1580 if( !xDocSh.Is() ) // Medium still needs to be deleted
1581 delete pMed;
1582
>>> CID 1340229: (RESOURCE_LEAK)
>>> Variable "pMed" going out of scope leaks the storage it points to.
1583 return 0;
1584 }
1585
/sw/source/uibase/app/docsh2.cxx: 1583 in SwFindDocShell(tools::SvRef<SfxObjectShell> &, SfxObjectShellLock &, const rtl::OUString &, const rtl::OUString &, const rtl::OUString &, short, SwDocShell *)()
1577 }
1578 }
1579
1580 if( !xDocSh.Is() ) // Medium still needs to be deleted
1581 delete pMed;
1582
>>> CID 1340229: (RESOURCE_LEAK)
>>> Variable "pMed" going out of scope leaks the storage it points to.
1583 return 0;
1584 }
1585
/sw/source/uibase/app/docsh2.cxx: 1583 in SwFindDocShell(tools::SvRef<SfxObjectShell> &, SfxObjectShellLock &, const rtl::OUString &, const rtl::OUString &, const rtl::OUString &, short, SwDocShell *)()
1577 }
1578 }
1579
1580 if( !xDocSh.Is() ) // Medium still needs to be deleted
1581 delete pMed;
1582
>>> CID 1340229: (RESOURCE_LEAK)
>>> Variable "pMed" going out of scope leaks the storage it points to.
1583 return 0;
1584 }
1585
/sw/source/uibase/app/docsh2.cxx: 1583 in SwFindDocShell(tools::SvRef<SfxObjectShell> &, SfxObjectShellLock &, const rtl::OUString &, const rtl::OUString &, const rtl::OUString &, short, SwDocShell *)()
1577 }
1578 }
1579
1580 if( !xDocSh.Is() ) // Medium still needs to be deleted
1581 delete pMed;
1582
>>> CID 1340229: (RESOURCE_LEAK)
>>> Variable "pMed" going out of scope leaks the storage it points to.
1583 return 0;
1584 }
1585
** CID 1340228: Resource leaks (RESOURCE_LEAK)
/sd/source/ui/dlg/navigatr.cxx: 652 in SdNavigatorWin::InsertFile(const rtl::OUString &)()
________________________________________________________________________________________________________
*** CID 1340228: Resource leaks (RESOURCE_LEAK)
/sd/source/ui/dlg/navigatr.cxx: 652 in SdNavigatorWin::InsertFile(const rtl::OUString &)()
646 }
647 else
648 {
649 delete pMedium;
650 return false;
651 }
>>> CID 1340228: Resource leaks (RESOURCE_LEAK)
>>> Variable "pMedium" going out of scope leaks the storage it points to.
652 }
653 else
654 {
655 return false;
656 }
657 }
** CID 1340227: Control flow issues (MISSING_BREAK)
/sd/source/ui/view/ViewShellBase.cxx: 1293 in sd::ViewShellBase::Implementation::GetSlotState(SfxItemSet &)()
________________________________________________________________________________________________________
*** CID 1340227: Control flow issues (MISSING_BREAK)
/sd/source/ui/view/ViewShellBase.cxx: 1293 in sd::ViewShellBase::Implementation::GetSlotState(SfxItemSet &)()
1287
1288 case SID_NOTES_MASTER_MODE:
1289 pFrameView = mrBase.GetMainViewShell()->GetFrameView();
1290 bState = pFrameView->GetViewShEditMode() == EM_MASTERPAGE
1291 && pFrameView->GetPageKind() == PK_NOTES;
1292
>>> CID 1340227: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
1293 case SID_TOGGLE_TABBAR_VISIBILITY:
1294 bState = GetUserWantsTabBar();
1295 break;
1296
1297 default:
1298 // Ignore all other items. They are not meant to be
** CID 1340226: Control flow issues (MISSING_BREAK)
/sd/source/ui/view/ViewShellBase.cxx: 1259 in sd::ViewShellBase::Implementation::GetSlotState(SfxItemSet &)()
________________________________________________________________________________________________________
*** CID 1340226: Control flow issues (MISSING_BREAK)
/sd/source/ui/view/ViewShellBase.cxx: 1259 in sd::ViewShellBase::Implementation::GetSlotState(SfxItemSet &)()
1253
1254 case SID_SLIDE_MASTER_MODE:
1255 pFrameView = mrBase.GetMainViewShell()->GetFrameView();
1256 bState = pFrameView->GetViewShEditMode() == EM_MASTERPAGE
1257 && pFrameView->GetPageKind() == PK_STANDARD;
1258
>>> CID 1340226: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
1259 case SID_SLIDE_SORTER_MULTI_PANE_GUI:
1260 case SID_SLIDE_SORTER_MODE:
1261 xResourceId = ResourceId::createWithAnchorURL(
1262 xContext,
1263 FrameworkHelper::msSlideSorterURL,
1264 FrameworkHelper::msCenterPaneURL);
** CID 1340225: Control flow issues (MISSING_BREAK)
/vcl/source/gdi/virdev.cxx: 168 in VirtualDevice::ImplInitVirDev(const OutputDevice *, long, long, DeviceFormat, const SystemGraphicsData *)()
________________________________________________________________________________________________________
*** CID 1340225: Control flow issues (MISSING_BREAK)
/vcl/source/gdi/virdev.cxx: 168 in VirtualDevice::ImplInitVirDev(const OutputDevice *, long, long, DeviceFormat, const SystemGraphicsData *)()
162
163 meFormat = eFormat;
164 switch (meFormat)
165 {
166 case DeviceFormat::BITMASK:
167 mnBitCount = 1;
>>> CID 1340225: Control flow issues (MISSING_BREAK)
>>> The above case falls through to this one.
168 default:
169 mnBitCount = pOutDev->GetBitCount();
170 break;
171 }
172 mnOutWidth = nDX;
173 mnOutHeight = nDY;
** CID 1340224: Control flow issues (DEADCODE)
/sc/source/filter/dif/difimp.cxx: 781 in DifParser::ScanFloatVal(const char16_t *)()
________________________________________________________________________________________________________
*** CID 1340224: Control flow issues (DEADCODE)
/sc/source/filter/dif/difimp.cxx: 781 in DifParser::ScanFloatVal(const char16_t *)()
775 if( IsNumberEnding( cAkt ) )
776 {
777 bRet = true; // to continue parsing
778 eS = S_END;
779 }
780 break;
>>> CID 1340224: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "case S_END:".
781 case S_END:
782 OSL_FAIL( "DifParser::ScanFloatVal - unexpected state" );
783 break;
784 default:
785 OSL_FAIL( "DifParser::ScanFloatVal - missing enum" );
786 }
** CID 1340222: Control flow issues (DEADCODE)
/sd/source/ui/view/drviewse.cxx: 1011 in sd::DrawViewShell::FuSupport(SfxRequest &)()
________________________________________________________________________________________________________
*** CID 1340222: Control flow issues (DEADCODE)
/sd/source/ui/view/drviewse.cxx: 1011 in sd::DrawViewShell::FuSupport(SfxRequest &)()
1005 sal_uInt16 nCount = GetDoc()->GetSdPageCount(PK_STANDARD);
1006
1007 while (i < nCount && !bFound)
1008 {
1009 SdPage* pPage = GetDoc()->GetSdPage(i, PK_STANDARD);
1010
>>> CID 1340222: Control flow issues (DEADCODE)
>>> Execution cannot reach the expression "pPage->GetAutoLayout() != AUTOLAYOUT_TITLE" inside this statement: "if (nSId == 27348 && pPage-...".
1011 if (nSId == SID_SLIDE_MASTER_MODE && pPage->GetAutoLayout() != AUTOLAYOUT_TITLE)
1012 {
1013 bFound = true;
1014 SwitchPage((pPage->GetPageNum() - 1) / 2);
1015 }
1016
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/libreoffice?tab=overview
To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939
More information about the LibreOffice
mailing list