Fw: My work

Jan Holesovsky kendy at collabora.com
Mon Oct 5 04:55:28 PDT 2015

Hi Jack,

Jack píše v So 03. 10. 2015 v 14:08 -0400:

> Due my slow internet connection, I am unable to upload my patches the
> regular way, so i am sending you my work in the attachment and in the
> following google drive
> folder(https://drive.google.com/file/d/0Bw9dWoxQQ7gNMUttaGctTm83Z00/view?usp=sharing). These are only small patches, I have changed two functions in writerfilter/source/dmapper/PropertyMap.cxx
> The file "fix.cxx" contains only the two functions, the file
> "PropertyMap.cxx" contains the whole patched file.

Thank you a lot for your changes; unfortunately this way makes it quite
hard for us to integrate :-(

Can you at least produce unified diff of the change; like:

diff -pu original_file.cxx changed_file.cxx > result.diff

and send us the diff?  Even better would be just to commit locally, and
send us the result of git format-patch - or send that directly to gerrit
using git push origin master:refs/for/master (as the others already
pointed out here).

Maybe it is not straight-forward the first time, but if you managed to
fix a problem in writerfilter, I'm sure handling git must be a piece of
cake for you :-)

More information here:


Thank you a lot!

All the best,

More information about the LibreOffice mailing list