Report from llvms static analysis tool

Daniel danlrobertson89 at gmail.com
Mon Oct 5 19:12:21 PDT 2015


> the problem is, should a legacy assertion be converted to assert or to
> SAL_WARN.  that is easy to answer in some cases (like when a pointer is
> asserted not to be null that is then unconditionally dereferenced), but
> in general requires some thought about whether it is trying to detect an
> invalid internal state, or just warn about a scenario that appeared
> unlikely to the author but is supposed to work even if it hasn't been
> tested - and that requires some experience.

Good point. I after looking through more of the DBG_ASSERTs in the
report you are definitely right. Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20151005/3f611af4/attachment.sig>


More information about the LibreOffice mailing list