OS checks with configuration time DLOPEN_NEEDS_LIBDL

[Norbert Thiebaud]

On Tue, Oct 20, 2015 at 1:39 AM, Richard PALO <richard at netbsd.org> wrote:
> Le 20/10/15 08:37, Norbert Thiebaud a écrit :
>> On Tue, Oct 20, 2015 at 1:11 AM, Richard PALO <richard at netbsd.org> wrote:
>>> Le 19/10/15 15:40, Norbert Thiebaud a écrit :
>>>> On Mon, Oct 19, 2015 at 3:13 AM, Richard PALO <richard at netbsd.org> wrote:
>>>>> Le 19/10/15 06:37, Norbert Thiebaud a écrit :
>>>>>>
>>>>>> On Sun, Oct 18, 2015 at 10:54 PM, Richard PALO <richard at netbsd.org> wrote:
>>>>>>>
>>>>>>>
>>>>>>> I'd like to advance, one way or another on this topic.
>>>>>>
>>>
>>> With the latest revision working on gerrit, I'm curious whether it would be preferable
>>> to pass directly the library, if needed.
>>>
>>> That is, instead of 'DLOPEN_NEEDS_LIBDL' being '' or 'TRUE', something like
>>> 'DLOPEN_LIBS' being either '' or '-ldl'.
>>>
>>> Then the usages would look like:
>>>>  $(eval $(call gb_Library_add_libs,sofficeapp,\
>>>> -    $(if $(filter $(OS),LINUX), \
>>>> -        -ldl \
>>>> +    $(if $(filter LINUX %BSD SOLARIS, $(OS)), \
>>>> +        $(DLOPEN_LIBS) \
>>
>> yeah.. but then it does not need to be in a $(if does it ?
>>
>> Norbert
>>
>>
>
> I believe, then, we would need to tackle '-lpthread' at the same time.
> Perhaps it is worth it?

not at the same time.. it is best to keep patch contained.. and no you
do not have to.. you can just move DLOPEN_LIBS one line up, outside of
the $(if$(filter for now...

Norbert