[Libreoffice-commits] core.git: 2 commits - editeng/source svx/source

[Eike Rathke]

Hi Caolán,

On Friday, 2015-10-23 01:13:40 -0700, Caolán McNamara wrote:

> -    LanguageType nTmpKey1 = eLang & 0x7ff, // the main language in many cases DE
> -                 nTmpKey2 = eLang & 0x3ff; // otherwise for example EN
> +    LanguageType nTmpKey1 = eLang & 0x7ff; // the main language in many cases DE

The mask 0x7ff looks wrong to me. The primary language ID mask is 0x3ff,
using 0x7ff includes one bit of the sublanguage ID, that combination is
(and was) somewhat arbitrary.. the old comment already had it wrong.

Btw, we have LANGUAGE_MASK_PRIMARY, best to use it ;)

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20151023/2fb47c8b/attachment.sig>