help request on proposed VCL code patch

[Lionel Elie Mamane]

Hi,

There is patch attached to tdf#94069, nominally a rather annoying Base
UI bug (crash!), but which touches the VCL event loop (not specific to
Base) in a way that I don't understand the consequences of (treat 10
events per call instead of 1...).

Would the right fix rather be to arrange for bHandleAllCurrentEvents
to be true in these specific circumstances? Or the Base UI code should
arrange for this not to be necessary in some way?

I'd appreciate if you could take a look at this patch/bug. Thanks in
advance.

On Mon, Oct 19, 2015 at 04:36:19PM +0000, bugzilla-daemon at bugs.documentfoundation.org wrote:
> https://bugs.documentfoundation.org/show_bug.cgi?id=94069
> 
> Lionel Elie Mamane <lionel at mamane.lu> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |caolanm at redhat.com
> 
> --- Comment #7 from Lionel Elie Mamane <lionel at mamane.lu> ---
> (In reply to Alex Thurgood from comment #6)
> > @Lionel: I see that you wern't yet on CC for this bug, but does the patch
> > provided by Donald look sane ?
> 
> Don't know, this is not database-code, but VCL code. Caolán? You have an
> opinion on this?
> 
> Maybe the right fix is to set bHandleAllCurrentEvents to true rather than
> changing the value for the case bHandleAllCurrentEvents == false?
> 

On Wed, Oct 28, 2015 at 10:05:25AM +0000, bugzilla-daemon at bugs.documentfoundation.org wrote:
> https://bugs.documentfoundation.org/show_bug.cgi?id=94069
> 
> --- Comment #8 from Alex Kempshall <mcmurchy1917-bugzilla at yahoo.co.uk> ---
> I've tested the patch, supplied by Donald Buczek, in master and it works for
> me.
> 
> Reading the other comments their seems to be a discussion as to whether the
> patch looks sane.
> 
> In the short term is it possible to apply the patch to master and then wait
> until something "saner" turns up.
> 
> At the moment we're frightening people with a locked desktop. 
> 
> btw the work around is to use the Size & Position dialog instead of dragging.
>