New Defects reported by Coverity Scan for LibreOffice

scan-admin at coverity.com scan-admin at coverity.com
Thu Sep 10 13:01:30 PDT 2015


Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

9 new defect(s) introduced to LibreOffice found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 9 of 9 defect(s)


** CID 1323760:  Uninitialized members  (UNINIT_CTOR)
/vcl/inc/salbmp.hxx: 44 in SalBitmap::SalBitmap()()


________________________________________________________________________________________________________
*** CID 1323760:  Uninitialized members  (UNINIT_CTOR)
/vcl/inc/salbmp.hxx: 44 in SalBitmap::SalBitmap()()
38     class VCL_PLUGIN_PUBLIC SalBitmap
39     {
40     public:
41     
42         typedef BitmapChecksum  ChecksumType;
43     
>>>     CID 1323760:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mnChecksum" is not initialized in this constructor nor in any functions that it calls.
44                                 SalBitmap() : mbChecksumValid(false) {}
45         virtual                 ~SalBitmap();
46     
47         virtual bool            Create( const Size& rSize,
48                                         sal_uInt16 nBitCount,
49                                         const BitmapPalette& rPal ) = 0;

** CID 1323759:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/opengl/OpenGLContext.cxx: 482 in <unnamed>::TempErrorHandler::TempErrorHandler(_XDisplay *, int (*)(_XDisplay *, XErrorEvent *))()


________________________________________________________________________________________________________
*** CID 1323759:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/opengl/OpenGLContext.cxx: 482 in <unnamed>::TempErrorHandler::TempErrorHandler(_XDisplay *, int (*)(_XDisplay *, XErrorEvent *))()
476             if (mdpy)
477             {
478                 XLockDisplay(dpy);
479                 XSync(dpy, false);
480                 oldErrorHandler = XSetErrorHandler(newErrorHandler);
481             }
>>>     CID 1323759:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "oldErrorHandler" is not initialized in this constructor nor in any functions that it calls.
482         }
483     
484         ~TempErrorHandler()
485         {
486             if (mdpy)
487             {

** CID 1323758:  Uninitialized members  (UNINIT_CTOR)
/vcl/workben/vcldemo.cxx: 1676 in OpenGLTests::OpenGLTests()()


________________________________________________________________________________________________________
*** CID 1323758:  Uninitialized members  (UNINIT_CTOR)
/vcl/workben/vcldemo.cxx: 1676 in OpenGLTests::OpenGLTests()()
1670             mxWinA(VclPtr<WorkWindow>::Create(nullptr, WB_APP | WB_STDWORK)),
1671             mxWinB(VclPtr<WorkWindow>::Create(nullptr, WB_APP | WB_STDWORK))
1672         {
1673             if (!OpenGLHelper::isVCLOpenGLEnabled())
1674             {
1675                 fprintf (stderr, "OpenGL is not enabled: try SAL_FORCEGL=1\n");
>>>     CID 1323758:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mpImplB" is not initialized in this constructor nor in any functions that it calls.
1676                 return;
1677             }
1678     
1679             mpImplA = getImpl(mxWinA);
1680             mpImplB = getImpl(mxWinB);
1681             assert (mpImplA && mpImplB);

** CID 1323757:    (REVERSE_INULL)
/sw/source/uibase/uno/unomod.cxx: 711 in SwXViewSettings::_setSingleValue(const comphelper::PropertyInfo &, const com::sun::star::uno::Any &)()
/sw/source/uibase/uno/unomod.cxx: 727 in SwXViewSettings::_setSingleValue(const comphelper::PropertyInfo &, const com::sun::star::uno::Any &)()


________________________________________________________________________________________________________
*** CID 1323757:    (REVERSE_INULL)
/sw/source/uibase/uno/unomod.cxx: 711 in SwXViewSettings::_setSingleValue(const comphelper::PropertyInfo &, const com::sun::star::uno::Any &)()
705                 mbApplyZoom = true;
706             }
707             break;
708             case HANDLE_VIEWSET_ONLINE_LAYOUT :
709             {
710                 SwViewOption aOpt(*pView->GetWrtShell().GetViewOptions());
>>>     CID 1323757:    (REVERSE_INULL)
>>>     Null-checking "this->pView" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
711                 if (pView && !bVal != !aOpt.getBrowseMode())
712                 {
713                     aOpt.setBrowseMode( bVal );
714                     pView->GetWrtShell().ApplyViewOptions( aOpt );
715     
716                     // must be set in mpViewOption as this will overwrite settings in _post!
/sw/source/uibase/uno/unomod.cxx: 727 in SwXViewSettings::_setSingleValue(const comphelper::PropertyInfo &, const com::sun::star::uno::Any &)()
721                 }
722             }
723             break;
724             case HANDLE_VIEWSET_HIDE_WHITESPACE:
725             {
726                 SwViewOption aOpt(*pView->GetWrtShell().GetViewOptions());
>>>     CID 1323757:    (REVERSE_INULL)
>>>     Null-checking "this->pView" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
727                 if (pView && !bVal != !aOpt.IsHideWhitespaceMode())
728                 {
729                     aOpt.SetHideWhitespaceMode( bVal );
730                     pView->GetWrtShell().ApplyViewOptions( aOpt );
731     
732                     // must be set in mpViewOption as this will overwrite settings in _post!

** CID 1323756:  Memory - illegal accesses  (OVERRUN)
/tools/source/stream/stream.cxx: 1908 in SvMemoryStream::ReAllocateMemory(long)()


________________________________________________________________________________________________________
*** CID 1323756:  Memory - illegal accesses  (OVERRUN)
/tools/source/stream/stream.cxx: 1908 in SvMemoryStream::ReAllocateMemory(long)()
1902             else
1903             {
1904                 if (nSize != 0)
1905                 {
1906                     memcpy( pNewBuf, pBuf, (size_t)nSize );
1907                 }
>>>     CID 1323756:  Memory - illegal accesses  (OVERRUN)
>>>     Overrunning dynamic array "pNewBuf" at offset corresponding to index variable "this->nSize" through dereference in call to "memset".
1908                 memset(pNewBuf + nSize, 0x00, nNewSize - nSize);
1909             }
1910     
1911             FreeMemory();
1912     
1913             pBuf  = pNewBuf;

** CID 1323755:  API usage errors  (INVALIDATE_ITERATOR)
/canvas/source/tools/pagemanager.cxx: 113 in canvas::PageManager::nakedFragment(const boost::shared_ptr<canvas::PageFragment> &)()


________________________________________________________________________________________________________
*** CID 1323755:  API usage errors  (INVALIDATE_ITERATOR)
/canvas/source/tools/pagemanager.cxx: 113 in canvas::PageManager::nakedFragment(const boost::shared_ptr<canvas::PageFragment> &)()
107                         }
108                     }
109                 }
110                 // this does not erase the candidate,
111                 // but makes it 'naked'...
112                 if( aCurrMax != aEnd )
>>>     CID 1323755:  API usage errors  (INVALIDATE_ITERATOR)
>>>     Dereferencing iterator "aCurrMax" though it is already past the end of its container.
113                     ( *aCurrMax )->free( *aCurrMax );
114                 else
115                     break;
116             }
117         }
118     

** CID 1323754:  Control flow issues  (DEADCODE)
/vcl/source/opengl/OpenGLHelper.cxx: 557 in OpenGLWatchdogThread::execute()()


________________________________________________________________________________________________________
*** CID 1323754:  Control flow issues  (DEADCODE)
/vcl/source/opengl/OpenGLHelper.cxx: 557 in OpenGLWatchdogThread::execute()()
551                     {
552                         SAL_WARN("vcl.opengl", "Watchdog gave up: aborting");
553                         gbWatchdogFiring = true;
554                         nUnchanged = 0;
555                         std::abort();
556                     }
>>>     CID 1323754:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "bAbortFired = true;".
557                     bAbortFired = true;
558                 }
559             }
560             else
561             {
562                 nUnchanged = 0;

** CID 1323753:  Control flow issues  (DEADCODE)
/svx/source/dialog/svxruler.cxx: 3245 in SvxRuler::StartDrag()()


________________________________________________________________________________________________________
*** CID 1323753:  Control flow issues  (DEADCODE)
/svx/source/dialog/svxruler.cxx: 3245 in SvxRuler::StartDrag()()
3239                 default:
3240                     nDragType = SvxRulerDragFlags::NONE;
3241             }
3242         }
3243         else
3244         {
>>>     CID 1323753:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "this->nDragType = SvxRulerD...".
3245             nDragType = SvxRulerDragFlags::NONE;
3246         }
3247     
3248         if(bOk)
3249             CalcMinMax();
3250     

** CID 1323752:  Control flow issues  (DEADCODE)
/vcl/source/edit/texteng.cxx: 2425 in TextEngine::CreateLines(unsigned int)()


________________________________________________________________________________________________________
*** CID 1323752:  Control flow issues  (DEADCODE)
/vcl/source/edit/texteng.cxx: 2425 in TextEngine::CreateLines(unsigned int)()
2419                                               pTEParaPortion->GetLines().end() );
2420         }
2421     
2422         DBG_ASSERT( pTEParaPortion->GetLines().size(), "CreateLines: No Line!" );
2423     
2424         if ( bLineBreak )
>>>     CID 1323752:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "this->CreateAndInsertEmptyL...".
2425             CreateAndInsertEmptyLine( nPara );
2426     
2427         pTEParaPortion->SetValid();
2428     
2429         return nOldLineCount != pTEParaPortion->GetLines().size();
2430     }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/libreoffice?tab=overview

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939



More information about the LibreOffice mailing list