[Libreoffice-commits] core.git: starmath: Prefix members of SmErrorDesc

Takeshi Abe tabe at fixedpoint.jp
Mon Sep 28 02:31:11 PDT 2015


Hi Stephan,

On Mon, 28 Sep 2015 10:38:54 +0200, Stephan Bergmann <sbergman at redhat.com> wrote:
> On 09/23/2015 07:39 AM, Takeshi Abe wrote:
>> commit 5ca4acf877834c51d896268cf3dd390903b2248b
(snip)
> Just a small remark: With "plain" structs that only contain (public, non-static)
> member variables and no member functions, it often makes sense to not decorate
> the member variable names.
> 
> As there are no member functions, there is never any ambiguity whether use of a
> name denotes a member or local variable, and accessing the member variables
> "from the outside" typically reads more natural as
> 
>   desc->pNode
> 
> than as
> 
>   desc->m_pNode
I agree the above argument is reasonable.
Thanks a lot for your remark.

Cheers,
-- Takeshi Abe


More information about the LibreOffice mailing list