New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1358589:  Uninitialized members  (UNINIT_CTOR)
/tools/source/generic/fract.cxx: 45 in Fraction::Impl::Impl()()


________________________________________________________________________________________________________
*** CID 1358589:  Uninitialized members  (UNINIT_CTOR)
/tools/source/generic/fract.cxx: 45 in Fraction::Impl::Impl()()
39     
40     struct Fraction::Impl
41     {
42         bool                        valid;
43         boost::rational<sal_Int64>  value;
44     
>>>     CID 1358589:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "valid" is not initialized in this constructor nor in any functions that it calls.
45         Impl() = default;
46         Impl(const Impl&) = delete;
47         Impl& operator=(const Impl&) = delete;
48     };
49     
50     Fraction::Fraction() : mpImpl(new Impl)

** CID 1358588:  Uninitialized members  (UNINIT_CTOR)
/smoketest/smoketest.cxx: 62 in <unnamed>::Result::Result()()


________________________________________________________________________________________________________
*** CID 1358588:  Uninitialized members  (UNINIT_CTOR)
/smoketest/smoketest.cxx: 62 in <unnamed>::Result::Result()()
56     namespace {
57     
58     struct Result {
59         osl::Condition condition;
60         bool success;
61         OUString result;
>>>     CID 1358588:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "success" is not initialized in this constructor nor in any functions that it calls.
62         Result() = default;
63         Result(const Result&) = delete;
64         Result& operator=(const Result&) = delete;
65     };
66     
67     class Listener:

** CID 1358587:  Error handling issues  (UNCAUGHT_EXCEPT)
/vcl/source/salmain/salmain.cxx: 35 in main()


________________________________________________________________________________________________________
*** CID 1358587:  Error handling issues  (UNCAUGHT_EXCEPT)
/vcl/source/salmain/salmain.cxx: 35 in main()
29     #include "salinst.hxx"
30     
31     #if defined( UNX ) && !defined MACOSX && !defined IOS && !defined ANDROID && !defined LIBO_HEADLESS
32     #include "opengl/x11/glxtest.hxx"
33     #endif
34     
>>>     CID 1358587:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     In function "main(int, char **)" an exception of type "boost::bad_rational" is thrown and never caught.
35     SAL_IMPLEMENT_MAIN() {
36     #if defined( UNX ) && !defined MACOSX && !defined IOS && !defined ANDROID && !defined LIBO_HEADLESS
37         fire_glxtest_process();
38     #endif
39         tools::extendApplicationEnvironment();
40         vclmain::createApplication();
41         return SVMain();
42     }
43     

** CID 1358586:  API usage errors  (INVALIDATE_ITERATOR)
/svx/source/accessibility/ChildrenManagerImpl.cxx: 385 in accessibility::ChildrenManagerImpl::MergeAccessibilityInformation(std::vector<accessibility::ChildDescriptor, std::allocator<accessibility::ChildDescriptor>> &)()


________________________________________________________________________________________________________
*** CID 1358586:  API usage errors  (INVALIDATE_ITERATOR)
/svx/source/accessibility/ChildrenManagerImpl.cxx: 385 in accessibility::ChildrenManagerImpl::MergeAccessibilityInformation(std::vector<accessibility::ChildDescriptor, std::allocator<accessibility::ChildDescriptor>> &)()
379         {
380             aOldChildDescriptor = ::std::find (maVisibleChildren.begin(), maVisibleChildren.end(), *I);
381     
382             // Copy accessible shape if that exists in the old descriptor.
383             bool bRegistrationIsNecessary = true;
384             if (aOldChildDescriptor != aEndVisibleChildren)
>>>     CID 1358586:  API usage errors  (INVALIDATE_ITERATOR)
>>>     Dereferencing iterator "aOldChildDescriptor" though it is already past the end of its container.
385                 if (aOldChildDescriptor->mxAccessibleShape.is())
386                 {
387                     I->mxAccessibleShape = aOldChildDescriptor->mxAccessibleShape;
388                     I->mbCreateEventPending = false;
389                     bRegistrationIsNecessary = false;
390                 }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/libreoffice?tab=overview

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939