[Libreoffice-commits] core.git: cppcheck style fix for noExplicitConstructor in writerfilter

[Miklos Vajna]

Hi,

On Tue, Dec 06, 2016 at 11:19:56AM +0100, Stephan Bergmann <sbergman at redhat.com> wrote:
> >accessMoved - Access of moved variable pReleasedFormat.
> 
> <http://dev-builds.libreoffice.org/cppcheck_reports/master/664.html#line-4657>
> looks OK, too:  SwDoc::DelTableStyle will either store pReleasedFormat in a
> new SwUndo and return an empty std::unique_ptr, or return pReleasedFormat.
> That code was added by <https://cgit.freedesktop.org/libreoffice/core/commit/?id=0943ee2decb8d5a1a2a5bf3b1c233934a89e9c97>
> "GSoC Writer Table Styles; Create by example; fix undo"---any further
> thoughts from its author or committer (on cc)?

Hm yes, warning on that unconditionally sounds like a way to generate
lots of false positives. ;-)

As said above, the member function returns nullptr exactly when the
format is already used for undo purposes, I don't see a problem with
that approach.

Regards,

Miklos
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20161206/ed0967da/attachment.sig>