[Libreoffice-commits] core.git: adjust rounding decimals to expected values

[Stephan Bergmann]

On 12/16/2016 07:40 PM, Eike Rathke wrote:
>  sc/qa/unit/data/functions/statistical/fods/forecast.ets.add.fods |  655 +++++-----
>  1 file changed, 346 insertions(+), 309 deletions(-)
>
> New commits:
> commit 8bd9e0503ebb6771c543e2fd9a0dc0d2d715f304
> Author: Eike Rathke <erack at redhat.com>
> Date:   Fri Dec 16 19:22:52 2016 +0100
>
>     adjust rounding decimals to expected values
>
>     This may have been the cause for some tinderboxes choking on this test
>     on Windows and Mac if the forecast results slightly differed due to the
>     initialization with random values and the calculation taking place with
>     a different internal floating point precision. So let's try.
>
>     Blindly throwing ROUND(...,12) at all values is wrong anyway because
>     that doesn't take the magnitude of the expected value into account. What
>     we actually want is an accuracy of 12 digits, not an accuracy of 12
>     decimals.
>
>     0.123456789012
>     1.23456789012
>     12.3456789012
>     123.456789012
>     ...
>
>     Change-Id: If88d75277c3d17cfd72f36d0f88d093b63da8add

...apparently doesn't fix the problem; 
<http://ci.libreoffice.org/job/lo_tb_master_mac_dbg/11172/console> still 
failed with

> Testing file:///Users/tdf/lode/jenkins/workspace/lo_tb_master_mac_dbg/sc/qa/unit/data/functions/statistical/fods/forecast.ets.add.fods:
> /Users/tdf/lode/jenkins/workspace/lo_tb_master_mac_dbg/sc/qa/unit/functions_test.cxx:43:StatisticalFunctionsTest::testStatisticalFormulasFODS
> double equality assertion failed
> - Expected: 1
> - Actual  : 0
> - Delta   : 1e-14