New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
30 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1351758:  Uninitialized members  (UNINIT_CTOR)
/vcl/inc/unx/gtk/gtkinst.hxx: 140 in GtkDragSource::GtkDragSource()()


________________________________________________________________________________________________________
*** CID 1351758:  Uninitialized members  (UNINIT_CTOR)
/vcl/inc/unx/gtk/gtkinst.hxx: 140 in GtkDragSource::GtkDragSource()()
134         osl::Mutex m_aMutex;
135         GtkSalFrame* m_pFrame;
136         css::uno::Reference<css::datatransfer::dnd::XDragSourceListener> m_xListener;
137         css::uno::Reference<css::datatransfer::XTransferable> m_xTrans;
138         VclToGtkHelper m_aConversionHelper;
139     public:
>>>     CID 1351758:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_pFrame" is not initialized in this constructor nor in any functions that it calls.
140         GtkDragSource() : WeakComponentImplHelper( m_aMutex ) {}
141         virtual ~GtkDragSource();
142     
143         // XDragSource
144         virtual sal_Bool    SAL_CALL isDragImageSupported() throw(std::exception) override;
145         virtual sal_Int32   SAL_CALL getDefaultCursor(sal_Int8 dragAction) throw(std::exception) override;

** CID 1351757:  Uninitialized members  (UNINIT_CTOR)
/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx: 168 in TiledWindow::TiledWindow()()


________________________________________________________________________________________________________
*** CID 1351757:  Uninitialized members  (UNINIT_CTOR)
/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx: 168 in TiledWindow::TiledWindow()()
162             m_pFindbarEntry(nullptr),
163             m_pFindbarLabel(nullptr),
164             m_bFindAll(false)
165         {
166             struct passwd* pPasswd = getpwuid(getuid());
167             m_aAuthor = std::string(pPasswd->pw_gecos);
>>>     CID 1351757:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_pDeleteComment" is not initialized in this constructor nor in any functions that it calls.
168         }
169     };
170     
171     static std::map<GtkWidget*, TiledWindow> g_aWindows;
172     
173     static void setupDocView(GtkWidget* pDocView);

** CID 1351756:  Null pointer dereferences  (REVERSE_INULL)
/wizards/com/sun/star/wizards/document/Control.java: 217 in com.sun.star.wizards.document.Control.getPreferredHeight()()


________________________________________________________________________________________________________
*** CID 1351756:  Null pointer dereferences  (REVERSE_INULL)
/wizards/com/sun/star/wizards/document/Control.java: 217 in com.sun.star.wizards.document.Control.getPreferredHeight()()
211                 return 2000;
212             }
213             else
214             {
215                 Size aPeerSize = getPeerSize();
216                 int nHeight = aPeerSize.Height;
>>>     CID 1351756:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "aPeerSize" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
217                 if (aPeerSize == null)
218                      nHeight = 0;
219                 else
220                      nHeight = aPeerSize.Height;
221     
222                 // We increase the preferred Height a bit so that the control does not become too small

** CID 1351755:  Null pointer dereferences  (NULL_RETURNS)
/sc/source/ui/dbgui/PivotLayoutDialog.cxx: 527 in ScPivotLayoutDialog::ApplyChanges()()


________________________________________________________________________________________________________
*** CID 1351755:  Null pointer dereferences  (NULL_RETURNS)
/sc/source/ui/dbgui/PivotLayoutDialog.cxx: 527 in ScPivotLayoutDialog::ApplyChanges()()
521                // range or to a new sheet
522                // FIXME: if the new range overlaps with the old one, the table actually doesn't move
523                // and shouldn't therefore be deleted
524                if ( !rOldRange.In( aDestinationRange )
525                     || (bToNewSheet && !mbNewPivotTable) )
526                {
>>>     CID 1351755:  Null pointer dereferences  (NULL_RETURNS)
>>>     Assigning: "pDPObj" = null return value from "GetDPAtCursor".
527                    ScDPObject *pDPObj = mpDocument->GetDPAtCursor( maPivotParameters.nCol, maPivotParameters.nRow, maPivotParameters.nTab);
528                    ScDBDocFunc aFunc( *(mpViewData->GetDocShell() ));
529                    aFunc.RemovePivotTable( *pDPObj, true, false);
530                    mpViewData->GetView()->CursorPosChanged();
531                }
532                return;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/libreoffice?tab=overview

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939