[Bug 86249] clean VirtualDevice constructor ...

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Fri Feb 12 09:44:20 UTC 2016


--- Comment #3 from Michael Meeks <michael.meeks at collabora.com> ---
I suspect the ambiguity is unpleasant - ie. if there are two constructors with
similar arguments we should have nice, readable, descriptive enum that
distinguishes between the two use-cases; rather than a random number that is
always the same value nAlphaBitCount added to the end =)

It seems we have:

ScopedVclPtrInstance<VirtualDevice> pDevice(&aData, Size(1, 1),

I wonder if we could overload something into the vdev creation along those
lines; not sure.

Beyond that the bigger problem is that VirtualDevices get created at a 1x1 size
initially - complete with OS resources behind them, which are slow & expensive
to create - and then we re-size them deleting the original stuff =) really the
creation needs to have a smoother flow that passes in the size correctly.

You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20160212/70b6dc57/attachment.html>

More information about the LibreOffice mailing list