unostyle.cxx: Repeatedly driving over changes of others ...
chris.sherlock79 at gmail.com
Tue Jan 19 15:45:54 PST 2016
OK, this is taking a little longer than I was expecting. I know exactly how to fix this, I’m afraid I was so embarrassed by the mistake I made that I forgot I was in the middle of another change I was making when I read this email that I fixed up the issue and managed to entangle that change in my fix.
Don’t worry, it’s not something I’ve committed to master, but I’m redoing the change now and doing another build on my local system. I’ll send this to gerrit and ensure it builds cleanly - I’ll update the list with the gerrit URL when I do so.
Once again, I deeply apologise for the error I made repeatedly. I’ve stopped all work on anything till I get this fixed, which I want to do in as clean a manner as possible.
> On 20 Jan 2016, at 7:37 AM, Chris Sherlock <chris.sherlock79 at gmail.com> wrote:
> Hey, I totally understand the feeling - I made a number of mistakes and compounded things greatly.
> It honestly shouldn’t take long to fix this - I just need to get the original file and then change all the GetName’s to GetFamilyName on that one file :-) The only limiting factor is how fast my computer will build sw!
> For the original issue, I’m going to start building on my own OS X machine and not rely on gerrit so much, and I’ll resurrect my Windows laptop (hopefully not on its last legs) and install lode. That should help with my build workflow, and take some pressure off the buildbots, and should prevent me from making mistakes like that in future.
>> On 20 Jan 2016, at 7:32 AM, Bjoern Michaelsen <bjoern.michaelsen at canonical.com> wrote:
>> Hi Chris,
>> On Wed, Jan 20, 2016 at 07:02:37AM +1100, Chris Sherlock wrote:
>>> I will fix this immediately.
>> Thanks, I was first confused by the source I saw lcov.libreoffice.org operating
>> on and then got a bit indignified when I figured out what happened looking at
>> the commit log. If this is fixed soonish, lets forget about this, no harm done.
More information about the LibreOffice