[Libreoffice-commits] core.git: desktop/source include/LibreOfficeKit

[Stephan Bergmann]

On 01/19/2016 04:38 PM, Miklos Vajna wrote:
> On Tue, Jan 19, 2016 at 06:39:56AM -0800, Oliver Specht <oliver.specht at cib.de> wrote:
>> diff --git a/include/LibreOfficeKit/LibreOfficeKit.h b/include/LibreOfficeKit/LibreOfficeKit.h
>> index 7d4210e..8057d75 100644
>> --- a/include/LibreOfficeKit/LibreOfficeKit.h
>> +++ b/include/LibreOfficeKit/LibreOfficeKit.h
>> @@ -51,6 +51,7 @@ struct _LibreOfficeKitClass
>>                                                const char* pURL);
>>
>>       char* (*getError) (LibreOfficeKit* pThis);
>> +    void  (*freeError)     (const char *pfree);
>>
>>       LibreOfficeKitDocument* (*documentLoadWithOptions) (LibreOfficeKit* pThis,
>>                                                           const char* pURL,
>
> Won't this break backwards compatibility with existing clients? I think
> you can only append new functions to the end of the function list,
> otherwise the LIBREOFFICEKIT_HAS_MEMBER() macro is quite pointless. ;-)

...and the usage of char* vs. char const* seems curiously inconsistent 
in that API