unostyle.cxx: Repeatedly driving over changes of others ...

[Chris Sherlock]

The buildbots have finally finished verifying the patch, it has been successful and I’ve pushed it to master. 

Bjoern, I hope that this is correct. I’ve carefully checked that the function is exactly the same as the one you committed, I’ve only made one change which was to modify the function that is called from GetName to GetFamilyName. 

If you see any issues, please let me know straight away - I don’t think there are any now though. 

Thanks for your patience. 

Chris

> On 20 Jan 2016, at 11:47 AM, Chris Sherlock <chris.sherlock79 at gmail.com> wrote:
> 
> I have submitted a fix to gerrit, waiting for Jenkins to verify this on all platforms. 
> 
> https://gerrit.libreoffice.org/#/c/21618/
> 
> Chris
> 
>> On 20 Jan 2016, at 7:37 AM, Chris Sherlock <chris.sherlock79 at gmail.com> wrote:
>> 
>> Hey, I totally understand the feeling - I made a number of mistakes and compounded things greatly. 
>> 
>> It honestly shouldn’t take long to fix this - I just need to get the original file and then change all the GetName’s to GetFamilyName on that one file :-) The only limiting factor is how fast my computer will build sw!
>> 
>> For the original issue, I’m going to start building on my own OS X machine and not rely on gerrit so much, and I’ll resurrect my Windows laptop (hopefully not on its last legs) and install lode. That should help with my build workflow, and take some pressure off the buildbots, and should prevent me from making mistakes like that in future. 
>> 
>> Chris
>> 
>> 
>>> On 20 Jan 2016, at 7:32 AM, Bjoern Michaelsen <bjoern.michaelsen at canonical.com> wrote:
>>> 
>>> Hi Chris,
>>> 
>>> On Wed, Jan 20, 2016 at 07:02:37AM +1100, Chris Sherlock wrote:
>>>> I will fix this immediately. 
>>> 
>>> Thanks, I was first confused by the source I saw lcov.libreoffice.org operating
>>> on and then got a bit indignified when I figured out what happened looking at
>>> the commit log. If this is fixed soonish, lets forget about this, no harm done.
>>> 
>>> Best,
>>> 
>>> Bjoern
>> 
>