New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
9 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1349759:  Null pointer dereferences  (FORWARD_NULL)
/qadevOOo/tests/java/ifc/io/_XOutputStream.java: 90 in ifc.io._XOutputStream._writeBytes()()


________________________________________________________________________________________________________
*** CID 1349759:  Null pointer dereferences  (FORWARD_NULL)
/qadevOOo/tests/java/ifc/io/_XOutputStream.java: 90 in ifc.io._XOutputStream._writeBytes()()
84             }
85     
86             byte[][] readData = new byte[1][data.length];
87             XInputStream xInStream = checker.getInStream();
88             if (xInStream == null) {
89                 try {
>>>     CID 1349759:  Null pointer dereferences  (FORWARD_NULL)
>>>     Calling a method on null object "xInStream".
90                     xInStream.readBytes(readData, data.length);
91                 } catch(com.sun.star.io.IOException e) {
92                     log.println("Couldn't read data:" + e);
93                     res = false;
94                 }
95             } else {

** CID 1349758:  Null pointer dereferences  (FORWARD_NULL)
/vcl/source/window/menu.cxx: 2517 in MenuBar::DeactivateMenuBar(VclPtr<vcl::Window> &)()


________________________________________________________________________________________________________
*** CID 1349758:  Null pointer dereferences  (FORWARD_NULL)
/vcl/source/window/menu.cxx: 2517 in MenuBar::DeactivateMenuBar(VclPtr<vcl::Window> &)()
2511         pMenuWin->PopupClosed(pMenu);
2512     }
2513     
2514     void MenuBar::DeactivateMenuBar(VclPtr<vcl::Window>& xFocusId)
2515     {
2516         MenuBarWindow* pMenuWin = getMenuBarWindow();
>>>     CID 1349758:  Null pointer dereferences  (FORWARD_NULL)
>>>     Comparing "pMenuWin" to null implies that "pMenuWin" might be null.
2517         xFocusId = pMenuWin ? pMenuWin->GetFocusId() : nullptr;
2518         if (xFocusId != nullptr)
2519         {
2520             pMenuWin->SetFocusId(nullptr);
2521             ImplGetSVData()->maWinData.mbNoDeactivate = false;
2522         }

** CID 1349757:  Error handling issues  (CHECKED_RETURN)
/hwpfilter/source/hfont.cxx: 83 in HWPFont::Read(HWPFile &)()


________________________________________________________________________________________________________
*** CID 1349757:  Error handling issues  (CHECKED_RETURN)
/hwpfilter/source/hfont.cxx: 83 in HWPFont::Read(HWPFile &)()
77     //printf("HWPFont::Read : lang = %d\n",NLanguage);
78         for(lang = 0; lang < NLanguage; lang++)
79         {
80             hwpf.Read2b(&nfonts, 1);
81             if (!(nfonts > 0 && nfonts < MAXFONTS))
82             {
>>>     CID 1349757:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "SetState" without checking return value (as is done elsewhere 28 out of 29 times).
83                 hwpf.SetState(HWP_InvalidFileFormat);
84                 return;
85             }
86             fontnames[lang] = new char[nfonts * FONTNAMELEN];
87     
88             memset(fontnames[lang], 0, nfonts * FONTNAMELEN);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/libreoffice?tab=overview

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939