Another C2220: warning treated as error with MSVC 2015

slacka lukebenes at hotmail.com
Sun Jul 24 18:04:01 UTC 2016


Can we trust MSVC 2015 unreachable code analysis like we with  this similar
issue?
<http://nabble.documentfoundation.org/New-C2220-warning-treated-as-error-MSVC-2015-build-failure-tc4187644.html#a4189119>  

The patch below fixes the build:

diff --git a/comphelper/source/misc/threadpool.cxx
b/comphelper/source/misc/threadpool.cxx
index 6846f4b..6a335e0 100644
--- a/comphelper/source/misc/threadpool.cxx
+++ b/comphelper/source/misc/threadpool.cxx
@@ -72,17 +72,7 @@ public:
             {
                 SAL_WARN("comphelper", "exception in thread worker while
calling doWork(): " << e.Message);
             }
-            try {
-                delete pTask;
-            }
-            catch (const std::exception &e)
-            {
-                SAL_WARN("comphelper", "exception in thread worker while
deleting task: " << e.what());
-            }
-            catch (const css::uno::Exception &e)
-            {
-                SAL_WARN("comphelper", "exception in thread worker while
deleting task: " << e.Message);
-            }
+            delete pTask;
             pTag->onTaskWorkerDone();
         }
     }






--
View this message in context: http://nabble.documentfoundation.org/C2220-warning-treated-as-error-64-bit-MSVC-2015-tp4184053p4189213.html
Sent from the Dev mailing list archive at Nabble.com.


More information about the LibreOffice mailing list