svl::SharedString::getDataIgnoreCase() returns unexpected result

Eike Rathke erack at redhat.com
Tue Jun 14 11:41:13 UTC 2016


Hi,

On Monday, 2016-06-13 22:37:34 -0400, Kohei Yoshida wrote:

> One likely scenario is where someone is passing a OUString value to a
> function that expects a SharedString.

An explicit svl::SharedString(const OUString&) ctor might help to
prevent accidental surprises.. done with
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=478613c550236d19b8254c49e5886dca1f0b8aac

Which additionally revealed a few places where SharedString::getString()
was called to pass an OUString& to create a SharedString ...

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20160614/c802e943/attachment.sig>


More information about the LibreOffice mailing list