Implementing SVG attribute "stroke-miterlimit" ( tdf#48066)
thb at libreoffice.org
Wed Mar 30 20:45:25 UTC 2016
Regina Henschel wrote:
> (1) Change the type of maStrokeMiterLimit' to 'double' and change its name
> to 'mfStrokeMiterLimit'. That would loose the ability to track, whether the
> value was found in the file or set by LO. In case not set in the SVG file,
> it would be set to 4.0, as specified as initial value in SVG spec.
Why would knowing if it's the default or read from svg matter?
> (2) Extend the enum SvgUnit by an item 'Unit_none'. This likely requires
> changes in places where SvgUnit is used. The member mfNumber of class
> SvgNumber is already a 'double' and would fit.
> My favorite is (2). What do you think?
I think you know the code better than I do, so whatever you prefer. :)
Except if the question above has the 'does not matter' answer, then of
course (1) seems cleaner ...
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 949 bytes
Desc: Digital signature
More information about the LibreOffice