Running external libraries testsuite (was: Re: libcmis: Google Drive login no longer working)

Rene Engelhard rene at
Mon May 2 07:31:12 UTC 2016


On Mon, May 02, 2016 at 09:26:07AM +0200, Giuseppe Castagno wrote:
> On 05/02/2016 09:17 AM, Miklos Vajna wrote:
> >Hi Giuseppe,
> >
> >On Thu, Apr 28, 2016 at 11:44:57AM +0200, Giuseppe Castagno <giuseppe.castagno at> wrote:
> >>I figured out a fix, for the time being as a patch in external/libcmis.
> >>
> >>In Linux it works, I'll test it on Windows before submitting to Gerrit.
> >
> >The would be very useful in libcmis upstream as well, Mihai anc Cedric has
> >commit rights there IIRC.
> thinking about it, I'm working on a more complete patch to update the unit
> tests in libcmis as well, libcmis tests are not used at LO compile time.

Which IMHO is a bug. We really should build with upstreams build systems
if possible (and not invent stuff) for external libraries and run the tests
to go sure the stuff we ship actually works...

Yes, this have somore more burden (cmake, anyone?) but I think it's worth.
We've (shipping all those as system libs) found test failures on
LO-supported archs (arm, see e.g. android, but maybe that feature was disabled
there, don't remember anymore) which noone cared about ;)



More information about the LibreOffice mailing list