Build warnings on Linux (strict-overflow in sc + unused variable in vcl)

[julien2412]

Hello,

On pc Debianx86-64 with master sources, I've got this error:
/home/julien/lo/libreoffice/sc/source/core/data/markmulti.cxx: In member
function ‘void ScMultiSel::SetMarkArea(SCCOL, SCCOL, SCROW, SCROW, bool)’:
/home/julien/lo/libreoffice/sc/source/core/data/markmulti.cxx:242:50: error:
assuming signed overflow does not occur when assuming that (X + c) >= X is
always true [-Werror=strict-overflow]
             while ( nBeg != MAXROWCOUNT && nLast < nEndRow )
                                                                                     
^
cc1plus: all warnings being treated as errors

Searching on Opengrok, here are their type:
SCROW nBeg, nLast = nEndRow + 1; (see
http://opengrok.libreoffice.org/xref/core/sc/source/core/data/markmulti.cxx#225)
void ScMultiSel::SetMarkArea( SCCOL nStartCol, SCCOL nEndCol, SCROW
nStartRow, SCROW nEndRow, bool bMark ) (line 206 of same file)

Other warning I got is:
/home/julien/lo/libreoffice/vcl/unx/gtk/gtksalmenu.cxx: In function
‘MenuAndId {anonymous}::decode_command(const gchar*)’:
/home/julien/lo/libreoffice/vcl/unx/gtk/gtksalmenu.cxx:892:17: error: unused
variable ‘sWindow’ [-Werror=unused-variable]
         OString sWindow = sCommand.getToken(0, '-', nIndex);
                        ^
Indeed sWindow is only used in line 898:
assert(sWindow == "window" && pSalSubMenu);

Of course, I could remove --enable-werror but would like to know how to fix
these warnings properly.

Any thoughts?

Julien



--
View this message in context: http://nabble.documentfoundation.org/Build-warnings-on-Linux-strict-overflow-in-sc-unused-variable-in-vcl-tp4183244.html
Sent from the Dev mailing list archive at Nabble.com.