New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

6 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)


** CID 1394273:  Memory - illegal accesses  (USE_AFTER_FREE)
/sc/source/core/tool/chgtrack.cxx: 293 in ScChangeAction::RemoveAllLinks()()


________________________________________________________________________________________________________
*** CID 1394273:  Memory - illegal accesses  (USE_AFTER_FREE)
/sc/source/core/tool/chgtrack.cxx: 293 in ScChangeAction::RemoveAllLinks()()
287         while ( pLinkAny )
288             delete pLinkAny; // Moves up by itself
289     
290         RemoveAllDeletedIn();
291     
292         while ( pLinkDeleted )
>>>     CID 1394273:  Memory - illegal accesses  (USE_AFTER_FREE)
>>>     Using freed pointer "this->pLinkDeleted".
293             delete pLinkDeleted; // Moves up by itself
294     
295         RemoveAllDependent();
296     }
297     
298     bool ScChangeAction::RemoveDeletedIn( const ScChangeAction* p )

** CID 1394272:  Memory - illegal accesses  (USE_AFTER_FREE)
/sc/source/core/tool/chgtrack.cxx: 288 in ScChangeAction::RemoveAllLinks()()


________________________________________________________________________________________________________
*** CID 1394272:  Memory - illegal accesses  (USE_AFTER_FREE)
/sc/source/core/tool/chgtrack.cxx: 288 in ScChangeAction::RemoveAllLinks()()
282         return pDel->IsMultiDelete() && (pDel->IsTopDelete() || pDel->IsRejectable());
283     }
284     
285     void ScChangeAction::RemoveAllLinks()
286     {
287         while ( pLinkAny )
>>>     CID 1394272:  Memory - illegal accesses  (USE_AFTER_FREE)
>>>     Using freed pointer "this->pLinkAny".
288             delete pLinkAny; // Moves up by itself
289     
290         RemoveAllDeletedIn();
291     
292         while ( pLinkDeleted )
293             delete pLinkDeleted; // Moves up by itself

** CID 1394271:  Control flow issues  (UNREACHABLE)
/vcl/unx/generic/window/salframe.cxx: 254 in lcl_SelectAppIconPixmap(SalDisplay *, SalX11Screen, unsigned short, unsigned short, unsigned long &, unsigned long &, std::vector<unsigned long, std::allocator<unsigned long>> &)()


________________________________________________________________________________________________________
*** CID 1394271:  Control flow issues  (UNREACHABLE)
/vcl/unx/generic/window/salframe.cxx: 254 in lcl_SelectAppIconPixmap(SalDisplay *, SalX11Screen, unsigned short, unsigned short, unsigned long &, unsigned long &, std::vector<unsigned long, std::allocator<unsigned long>> &)()
248     
249     static bool lcl_SelectAppIconPixmap( SalDisplay *pDisplay, SalX11Screen nXScreen,
250                                              sal_uInt16 nIcon, sal_uInt16 iconSize,
251                                              Pixmap& icon_pixmap, Pixmap& icon_mask, NetWmIconData& netwm_icon)
252     {
253         return true;
>>>     CID 1394271:  Control flow issues  (UNREACHABLE)
>>>     This code cannot be reached: "if (!ImplGetResMgr())
  ret...".
254         if( ! ImplGetResMgr() )
255             return false;
256     
257         CreateNetWmAppIcon( nIcon, netwm_icon );
258     
259         sal_uInt16 nIconSizeOffset;

** CID 1394270:  Error handling issues  (UNCAUGHT_EXCEPT)
/sd/source/ui/unoidl/unoobj.cxx: 897 in SdXShape::IsEmptyPresObj() const()


________________________________________________________________________________________________________
*** CID 1394270:  Error handling issues  (UNCAUGHT_EXCEPT)
/sd/source/ui/unoidl/unoobj.cxx: 897 in SdXShape::IsEmptyPresObj() const()
891         }
892         return false;
893     }
894     
895     /** checks if this presentation object is empty
896      */
>>>     CID 1394270:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "std::length_error" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
897     bool SdXShape::IsEmptyPresObj() const throw()
898     {
899         SdrObject* pObj = mpShape->GetSdrObject();
900         if( (pObj != nullptr) && pObj->IsEmptyPresObj() )
901         {
902             // check if the object is in edit, than its temporarily not empty

** CID 1394269:  Error handling issues  (UNCAUGHT_EXCEPT)
/sd/source/ui/unoidl/unoobj.cxx: 897 in SdXShape::IsEmptyPresObj() const()


________________________________________________________________________________________________________
*** CID 1394269:  Error handling issues  (UNCAUGHT_EXCEPT)
/sd/source/ui/unoidl/unoobj.cxx: 897 in SdXShape::IsEmptyPresObj() const()
891         }
892         return false;
893     }
894     
895     /** checks if this presentation object is empty
896      */
>>>     CID 1394269:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "com::sun::star::uno::DeploymentException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
897     bool SdXShape::IsEmptyPresObj() const throw()
898     {
899         SdrObject* pObj = mpShape->GetSdrObject();
900         if( (pObj != nullptr) && pObj->IsEmptyPresObj() )
901         {
902             // check if the object is in edit, than its temporarily not empty

** CID 1394268:  Resource leaks  (RESOURCE_LEAK)
/svx/source/table/cell.cxx: 329 in sdr::properties::CellProperties::ItemChange(unsigned short, const SfxPoolItem *)()


________________________________________________________________________________________________________
*** CID 1394268:  Resource leaks  (RESOURCE_LEAK)
/svx/source/table/cell.cxx: 329 in sdr::properties::CellProperties::ItemChange(unsigned short, const SfxPoolItem *)()
323                         pParaObj = mxCell->GetOutlinerParaObject();
324                     if(pParaObj)
325                     {
326                         pParaObj->SetVertical(bVertical);
327                     }
328     
>>>     CID 1394268:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "pParaObj" going out of scope leaks the storage it points to.
329                 }
330     
331                 // call parent
332                 AttributeProperties::ItemChange( nWhich, pNewItem );
333             }
334     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy4uRAMjUqSCLy7rxyAGDqNjtJ7DiPsYnqm3GhHMub2fj3snVUmBOa1GfIw1X8-2FDCriEILKCq3zGrgajxziI4YgTZSkwTttSw82Ndo4SViMsdYNVCX-2FrGlh8srv5FX87oWmVMiDvFZ7mNtmw4RVxD6-2B1tyCAbwj5lGcrKvW7KAr3o-3D

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy4uRAMjUqSCLy7rxyAGDqNoC7Htze-2BGD7YOKQYIRMqsXkqoIjRtBXAayGx9iwioB-2FZ3t-2BkHP8d7bV9kd1qLqwuRbi5vafbrqVND70GZVWuSIUcpMyUUZVeASO8upKD-2Frj1UomaEE6rniMaVUMrexfolLESIDTPeR4KiCnkZ-2Ftcq8-3D