New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
6 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1373665:  Incorrect expression  (USELESS_CALL)


________________________________________________________________________________________________________
*** CID 1373665:  Incorrect expression  (USELESS_CALL)
/vcl/source/control/combobox.cxx: 172 in ComboBox::ImplInit(vcl::Window *, long)()
166                 m_pImpl->m_nDDHeight = sal::static_int_cast<sal_uInt16>(nNCHeight);
167         }
168     }
169     
170     void ComboBox::ImplInit( vcl::Window* pParent, WinBits nStyle )
171     {
>>>     CID 1373665:  Incorrect expression  (USELESS_CALL)
>>>     Calling "ComboBox::ImplInitStyle(nStyle)" is only useful for its return value, which is ignored.
172         ImplInitStyle( nStyle );
173     
174         bool bNoBorder = ( nStyle & WB_NOBORDER ) != 0;
175         if ( !(nStyle & WB_DROPDOWN) )
176         {
177             nStyle &= ~WB_BORDER;

** CID 1373664:  Uninitialized members  (UNINIT_CTOR)
/cui/source/tabpages/tabarea.cxx: 89 in SvxAreaTabDialog::SvxAreaTabDialog(vcl::Window *, const SfxItemSet *, SdrModel *, bool)()


________________________________________________________________________________________________________
*** CID 1373664:  Uninitialized members  (UNINIT_CTOR)
/cui/source/tabpages/tabarea.cxx: 89 in SvxAreaTabDialog::SvxAreaTabDialog(vcl::Window *, const SfxItemSet *, SdrModel *, bool)()
83         m_nTransparenceTabPage = AddTabPage( "RID_SVXPAGE_TRANSPARENCE", SvxTransparenceTabPage::Create,  nullptr);
84     
85         SetCurPageId( "RID_SVXPAGE_AREA" );
86     
87         CancelButton& rBtnCancel = GetCancelButton();
88         rBtnCancel.SetClickHdl( LINK( this, SvxAreaTabDialog, CancelHdlImpl ) );
>>>     CID 1373664:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mbAreaTP" is not initialized in this constructor nor in any functions that it calls.
89     }
90     
91     void SvxAreaTabDialog::SavePalettes()
92     {
93         SfxObjectShell* pShell = SfxObjectShell::Current();
94         if( mpNewColorList != mpDrawModel->GetColorList() )

** CID 1373663:  Insecure data handling  (TAINTED_SCALAR)
/comphelper/source/misc/backupfilehelper.cxx: 434 in <unnamed>::ExtensionInfo::read_entries(std::shared_ptr<osl::File> &)()


________________________________________________________________________________________________________
*** CID 1373663:  Insecure data handling  (TAINTED_SCALAR)
/comphelper/source/misc/backupfilehelper.cxx: 434 in <unnamed>::ExtensionInfo::read_entries(std::shared_ptr<osl::File> &)()
428     
429                 if (!read_sal_uInt32(rFile, nExtEntries))
430                 {
431                     return false;
432                 }
433     
>>>     CID 1373663:  Insecure data handling  (TAINTED_SCALAR)
>>>     Using tainted variable "nExtEntries" as a loop boundary.
434                 for (sal_uInt32 a(0); a < nExtEntries; a++)
435                 {
436                     ExtensionInfoEntry aNewEntry;
437     
438                     if (aNewEntry.read_entry(rFile))
439                     {

** CID 1373662:  Insecure data handling  (TAINTED_SCALAR)
/vcl/source/control/listbox.cxx: 201 in ListBox::ImplLoadRes()()


________________________________________________________________________________________________________
*** CID 1373662:  Insecure data handling  (TAINTED_SCALAR)
/vcl/source/control/listbox.cxx: 201 in ListBox::ImplLoadRes()()
195     
196         // The resource short is actually to be treated as unsigned short.
197         sal_uInt16 nResPos = static_cast<sal_uInt16>(ReadShortRes());
198         sal_Int32 nSelPos = (nResPos == SAL_MAX_UINT16) ? LISTBOX_ENTRY_NOTFOUND : nResPos;
199         sal_Int32 nNumber = ReadLongRes();
200     
>>>     CID 1373662:  Insecure data handling  (TAINTED_SCALAR)
>>>     Using tainted variable "nNumber" as a loop boundary.
201         for( sal_Int32 i = 0; i < nNumber; i++ )
202         {
203             sal_Int32 nPos = InsertEntry( ReadStringRes() );
204     
205             sal_IntPtr nId = ReadLongRes();
206             if( nId )


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyGRQLPsJ4rfZ-2ByhtOe45xVen5IFJTX9GobMUFZVAWOdSOxMcf0lACl6ypuFtSyV1ORh8uYNLmyLPBSEB0Ze0adiUX7elBQRQPqUDRsQo9XMtk-2Bnq09mVoYwz1zQY9kogEj78e5Qfhn55k0RXgTL-2FLdBhpUbsL0E-2BkS8WErta45Sk-3D

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyGRQLPsJ4rfZ-2ByhtOe45xVTC5-2FUPqpdfPhsolHOA9CiAN2M-2FwpeAyY1Bh7KjWR9GxDkWDUUPHxwf5i68Iy1isUx2FW6U9rKYgiJS37ghWtBg3eIVsiNyBaq6DxDS6N34chbQx1SIufIGoCE5brFcNLX3l8-2FTHEBs4CJY8CMaAPmQ-3D