New Defects reported by Coverity Scan for LibreOffice

scan-admin at coverity.com scan-admin at coverity.com
Mon Apr 3 08:17:09 UTC 2017


Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

10 new defect(s) introduced to LibreOffice found with Coverity Scan.
18 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 10 of 10 defect(s)


** CID 1403739:    (TAINTED_SCALAR)
/filter/source/graphicfilter/ipict/ipict.cxx: 952 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
/filter/source/graphicfilter/ipict/ipict.cxx: 1096 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
/filter/source/graphicfilter/ipict/ipict.cxx: 1143 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
/filter/source/graphicfilter/ipict/ipict.cxx: 1143 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
/filter/source/graphicfilter/ipict/ipict.cxx: 1143 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
/filter/source/graphicfilter/ipict/ipict.cxx: 1143 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
/filter/source/graphicfilter/ipict/ipict.cxx: 1143 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
/filter/source/graphicfilter/ipict/ipict.cxx: 1143 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
/filter/source/graphicfilter/ipict/ipict.cxx: 1112 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()


________________________________________________________________________________________________________
*** CID 1403739:    (TAINTED_SCALAR)
/filter/source/graphicfilter/ipict/ipict.cxx: 952 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
946                     return 0xffffffff;
947             }
948     
949             if ( ( pAcc = initBitmap(aBitmap, nWidth, nHeight, nDstBitCount, aPalette) ) == nullptr )
950                 return 0xffffffff;
951     
>>>     CID 1403739:    (TAINTED_SCALAR)
>>>     Using tainted variable "nHeight" as a loop boundary.
952             for (sal_uInt16 ny = 0; ny < nHeight; ++ny)
953             {
954                 sal_uInt16 nx = 0;
955                 if ( nRowBytes < 8 || nPackType == 1 )
956                 {
957                     for (size_t i = 0; i < nWidth; ++i)
/filter/source/graphicfilter/ipict/ipict.cxx: 1096 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
1090                     if (nHeight > pPict->remainingSize() / nByteCountSize)
1091                         return 0xffffffff;
1092     
1093                     if ( ( pAcc = initBitmap(aBitmap, nWidth, nHeight, nDstBitCount, aPalette) ) == nullptr )
1094                         return 0xffffffff;
1095     
>>>     CID 1403739:    (TAINTED_SCALAR)
>>>     Passing tainted variable "static_cast<size_t>(nWidth) * nCmpCount" to a tainted sink.
1096                     std::unique_ptr<sal_uInt8[]> pScanline(new sal_uInt8[static_cast<size_t>(nWidth) * nCmpCount]);
1097                     for (sal_uInt16 ny = 0; ny < nHeight; ++ny)
1098                     {
1099                         nSrcBitsPos = pPict->Tell();
1100                         if ( nRowBytes > 250 )
1101                         {
/filter/source/graphicfilter/ipict/ipict.cxx: 1143 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
1137                                     pScanline[ i++ ] = nDat;
1138                             }
1139                         }
1140                         sal_uInt8* pTmp = pScanline.get();
1141                         if ( nCmpCount == 4 )
1142                             pTmp += nWidth;
>>>     CID 1403739:    (TAINTED_SCALAR)
>>>     Using tainted variable "nWidth" as a loop boundary.
1143                         for (sal_uInt16 nx = 0; nx < nWidth; pTmp++)
1144                             pAcc->SetPixel( ny, nx++, BitmapColor( *pTmp, pTmp[ nWidth ], pTmp[ 2 * nWidth ] ) );
1145                         nDataSize += (sal_uLong)nByteCount;
1146                         pPict->Seek( nSrcBitsPos + (sal_uLong)nByteCount );
1147                     }
1148                 }
/filter/source/graphicfilter/ipict/ipict.cxx: 1143 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
1137                                     pScanline[ i++ ] = nDat;
1138                             }
1139                         }
1140                         sal_uInt8* pTmp = pScanline.get();
1141                         if ( nCmpCount == 4 )
1142                             pTmp += nWidth;
>>>     CID 1403739:    (TAINTED_SCALAR)
>>>     Using tainted variable "nWidth" as a loop boundary.
1143                         for (sal_uInt16 nx = 0; nx < nWidth; pTmp++)
1144                             pAcc->SetPixel( ny, nx++, BitmapColor( *pTmp, pTmp[ nWidth ], pTmp[ 2 * nWidth ] ) );
1145                         nDataSize += (sal_uLong)nByteCount;
1146                         pPict->Seek( nSrcBitsPos + (sal_uLong)nByteCount );
1147                     }
1148                 }
/filter/source/graphicfilter/ipict/ipict.cxx: 1143 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
1137                                     pScanline[ i++ ] = nDat;
1138                             }
1139                         }
1140                         sal_uInt8* pTmp = pScanline.get();
1141                         if ( nCmpCount == 4 )
1142                             pTmp += nWidth;
>>>     CID 1403739:    (TAINTED_SCALAR)
>>>     Using tainted variable "nWidth" as a loop boundary.
1143                         for (sal_uInt16 nx = 0; nx < nWidth; pTmp++)
1144                             pAcc->SetPixel( ny, nx++, BitmapColor( *pTmp, pTmp[ nWidth ], pTmp[ 2 * nWidth ] ) );
1145                         nDataSize += (sal_uLong)nByteCount;
1146                         pPict->Seek( nSrcBitsPos + (sal_uLong)nByteCount );
1147                     }
1148                 }
/filter/source/graphicfilter/ipict/ipict.cxx: 1143 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
1137                                     pScanline[ i++ ] = nDat;
1138                             }
1139                         }
1140                         sal_uInt8* pTmp = pScanline.get();
1141                         if ( nCmpCount == 4 )
1142                             pTmp += nWidth;
>>>     CID 1403739:    (TAINTED_SCALAR)
>>>     Using tainted variable "nWidth" as a loop boundary.
1143                         for (sal_uInt16 nx = 0; nx < nWidth; pTmp++)
1144                             pAcc->SetPixel( ny, nx++, BitmapColor( *pTmp, pTmp[ nWidth ], pTmp[ 2 * nWidth ] ) );
1145                         nDataSize += (sal_uLong)nByteCount;
1146                         pPict->Seek( nSrcBitsPos + (sal_uLong)nByteCount );
1147                     }
1148                 }
/filter/source/graphicfilter/ipict/ipict.cxx: 1143 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
1137                                     pScanline[ i++ ] = nDat;
1138                             }
1139                         }
1140                         sal_uInt8* pTmp = pScanline.get();
1141                         if ( nCmpCount == 4 )
1142                             pTmp += nWidth;
>>>     CID 1403739:    (TAINTED_SCALAR)
>>>     Using tainted variable "nWidth" as a loop boundary.
1143                         for (sal_uInt16 nx = 0; nx < nWidth; pTmp++)
1144                             pAcc->SetPixel( ny, nx++, BitmapColor( *pTmp, pTmp[ nWidth ], pTmp[ 2 * nWidth ] ) );
1145                         nDataSize += (sal_uLong)nByteCount;
1146                         pPict->Seek( nSrcBitsPos + (sal_uLong)nByteCount );
1147                     }
1148                 }
/filter/source/graphicfilter/ipict/ipict.cxx: 1143 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
1137                                     pScanline[ i++ ] = nDat;
1138                             }
1139                         }
1140                         sal_uInt8* pTmp = pScanline.get();
1141                         if ( nCmpCount == 4 )
1142                             pTmp += nWidth;
>>>     CID 1403739:    (TAINTED_SCALAR)
>>>     Using tainted variable "nWidth" as a loop boundary.
1143                         for (sal_uInt16 nx = 0; nx < nWidth; pTmp++)
1144                             pAcc->SetPixel( ny, nx++, BitmapColor( *pTmp, pTmp[ nWidth ], pTmp[ 2 * nWidth ] ) );
1145                         nDataSize += (sal_uLong)nByteCount;
1146                         pPict->Seek( nSrcBitsPos + (sal_uLong)nByteCount );
1147                     }
1148                 }
/filter/source/graphicfilter/ipict/ipict.cxx: 1112 in PictReader::ReadPixMapEtc(Bitmap &, bool, bool, tools::Rectangle *, tools::Rectangle *, bool, bool)()
1106                         {
1107                             pPict->ReadUChar( nByteCountAsByte );
1108                             nByteCount = nByteCountAsByte;
1109                             nByteCount++;
1110                         }
1111                         size_t i = 0;
>>>     CID 1403739:    (TAINTED_SCALAR)
>>>     Using tainted variable "(sal_uInt32)(nWidth * nCmpCount)" as a loop boundary.
1112                         while( i < (sal_uInt32)( nWidth * nCmpCount ) )
1113                         {
1114                             pPict->ReadUChar( nFlagCounterByte );
1115                             if ( ( nFlagCounterByte & 0x80 ) == 0)
1116                             {
1117                                 nCount = ( (sal_uInt16)nFlagCounterByte ) + 1;

** CID 1403738:    (OVERFLOW_BEFORE_WIDEN)
/filter/source/graphicfilter/itiff/itiff.cxx: 852 in TIFFReader::ConvertScanline(int)()
/filter/source/graphicfilter/itiff/itiff.cxx: 853 in TIFFReader::ConvertScanline(int)()
/filter/source/graphicfilter/itiff/itiff.cxx: 854 in TIFFReader::ConvertScanline(int)()


________________________________________________________________________________________________________
*** CID 1403738:    (OVERFLOW_BEFORE_WIDEN)
/filter/source/graphicfilter/itiff/itiff.cxx: 852 in TIFFReader::ConvertScanline(int)()
846                 {
847                     sal_uLong nMinMax = nMinSampleValue * 255 / ( nMaxSampleValue - nMinSampleValue );
848                     for (sal_Int32 nx = 0; nx < nImageWidth; ++nx)
849                     {
850                         if ( nPlanes < 3 )
851                         {
>>>     CID 1403738:    (OVERFLOW_BEFORE_WIDEN)
>>>     Potentially overflowing expression "nx * this->nSamplesPerPixel" with type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "sal_uLong" (64 bits, unsigned).
852                             nRed = GetBits( pMap[ 0 ], ( nx * nSamplesPerPixel + 0 ) * nBitsPerSample, nBitsPerSample );
853                             nGreen = GetBits( pMap[ 1 ], ( nx * nSamplesPerPixel + 1 ) * nBitsPerSample, nBitsPerSample );
854                             nBlue = GetBits( pMap[ 2 ], ( nx * nSamplesPerPixel + 2 ) * nBitsPerSample, nBitsPerSample );
855                         }
856                         else
857                         {
/filter/source/graphicfilter/itiff/itiff.cxx: 853 in TIFFReader::ConvertScanline(int)()
847                     sal_uLong nMinMax = nMinSampleValue * 255 / ( nMaxSampleValue - nMinSampleValue );
848                     for (sal_Int32 nx = 0; nx < nImageWidth; ++nx)
849                     {
850                         if ( nPlanes < 3 )
851                         {
852                             nRed = GetBits( pMap[ 0 ], ( nx * nSamplesPerPixel + 0 ) * nBitsPerSample, nBitsPerSample );
>>>     CID 1403738:    (OVERFLOW_BEFORE_WIDEN)
>>>     Potentially overflowing expression "nx * this->nSamplesPerPixel" with type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "sal_uLong" (64 bits, unsigned).
853                             nGreen = GetBits( pMap[ 1 ], ( nx * nSamplesPerPixel + 1 ) * nBitsPerSample, nBitsPerSample );
854                             nBlue = GetBits( pMap[ 2 ], ( nx * nSamplesPerPixel + 2 ) * nBitsPerSample, nBitsPerSample );
855                         }
856                         else
857                         {
858                             nRed = GetBits( pMap[ 0 ], nx * nBitsPerSample, nBitsPerSample );
/filter/source/graphicfilter/itiff/itiff.cxx: 854 in TIFFReader::ConvertScanline(int)()
848                     for (sal_Int32 nx = 0; nx < nImageWidth; ++nx)
849                     {
850                         if ( nPlanes < 3 )
851                         {
852                             nRed = GetBits( pMap[ 0 ], ( nx * nSamplesPerPixel + 0 ) * nBitsPerSample, nBitsPerSample );
853                             nGreen = GetBits( pMap[ 1 ], ( nx * nSamplesPerPixel + 1 ) * nBitsPerSample, nBitsPerSample );
>>>     CID 1403738:    (OVERFLOW_BEFORE_WIDEN)
>>>     Potentially overflowing expression "nx * this->nSamplesPerPixel" with type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "sal_uLong" (64 bits, unsigned).
854                             nBlue = GetBits( pMap[ 2 ], ( nx * nSamplesPerPixel + 2 ) * nBitsPerSample, nBitsPerSample );
855                         }
856                         else
857                         {
858                             nRed = GetBits( pMap[ 0 ], nx * nBitsPerSample, nBitsPerSample );
859                             nGreen = GetBits( pMap[ 1 ], nx * nBitsPerSample, nBitsPerSample );

** CID 1403737:  Incorrect expression  (MIXED_ENUMS)
/sw/source/ui/frmdlg/frmpage.cxx: 1817 in SwFramePage::RangeModifyHdl()()


________________________________________________________________________________________________________
*** CID 1403737:  Incorrect expression  (MIXED_ENUMS)
/sw/source/ui/frmdlg/frmpage.cxx: 1817 in SwFramePage::RangeModifyHdl()()
1811         SwWrtShell* pSh = m_bFormat ? ::GetActiveWrtShell()
1812                             : getFrameDlgParentShell();
1813         OSL_ENSURE(pSh , "shell not found");
1814         SwFlyFrameAttrMgr aMgr( m_bNew, pSh, static_cast<const SwAttrSet&>(GetItemSet()) );
1815         SvxSwFrameValidation        aVal;
1816     
>>>     CID 1403737:  Incorrect expression  (MIXED_ENUMS)
>>>     Mixing enum types "com::sun::star::text::TextContentAnchorType" and "RndStdIds" for "nAnchorType".
1817         aVal.nAnchorType = (css::text::TextContentAnchorType)GetAnchor();
1818         aVal.bAutoHeight = m_pAutoHeightCB->IsChecked();
1819         aVal.bAutoWidth = m_pAutoWidthCB->IsChecked();
1820         aVal.bMirror = m_pMirrorPagesCB->IsChecked();
1821         aVal.bFollowTextFlow = m_pFollowTextFlowCB->IsChecked();
1822     

** CID 1403736:    (OVERFLOW_BEFORE_WIDEN)
/filter/source/graphicfilter/itiff/itiff.cxx: 852 in TIFFReader::ConvertScanline(int)()
/filter/source/graphicfilter/itiff/itiff.cxx: 853 in TIFFReader::ConvertScanline(int)()
/filter/source/graphicfilter/itiff/itiff.cxx: 854 in TIFFReader::ConvertScanline(int)()
/filter/source/graphicfilter/itiff/itiff.cxx: 877 in TIFFReader::ConvertScanline(int)()


________________________________________________________________________________________________________
*** CID 1403736:    (OVERFLOW_BEFORE_WIDEN)
/filter/source/graphicfilter/itiff/itiff.cxx: 852 in TIFFReader::ConvertScanline(int)()
846                 {
847                     sal_uLong nMinMax = nMinSampleValue * 255 / ( nMaxSampleValue - nMinSampleValue );
848                     for (sal_Int32 nx = 0; nx < nImageWidth; ++nx)
849                     {
850                         if ( nPlanes < 3 )
851                         {
>>>     CID 1403736:    (OVERFLOW_BEFORE_WIDEN)
>>>     Potentially overflowing expression "(nx * this->nSamplesPerPixel + 0U) * this->nBitsPerSample" with type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "sal_uLong" (64 bits, unsigned).
852                             nRed = GetBits( pMap[ 0 ], ( nx * nSamplesPerPixel + 0 ) * nBitsPerSample, nBitsPerSample );
853                             nGreen = GetBits( pMap[ 1 ], ( nx * nSamplesPerPixel + 1 ) * nBitsPerSample, nBitsPerSample );
854                             nBlue = GetBits( pMap[ 2 ], ( nx * nSamplesPerPixel + 2 ) * nBitsPerSample, nBitsPerSample );
855                         }
856                         else
857                         {
/filter/source/graphicfilter/itiff/itiff.cxx: 853 in TIFFReader::ConvertScanline(int)()
847                     sal_uLong nMinMax = nMinSampleValue * 255 / ( nMaxSampleValue - nMinSampleValue );
848                     for (sal_Int32 nx = 0; nx < nImageWidth; ++nx)
849                     {
850                         if ( nPlanes < 3 )
851                         {
852                             nRed = GetBits( pMap[ 0 ], ( nx * nSamplesPerPixel + 0 ) * nBitsPerSample, nBitsPerSample );
>>>     CID 1403736:    (OVERFLOW_BEFORE_WIDEN)
>>>     Potentially overflowing expression "(nx * this->nSamplesPerPixel + 1U) * this->nBitsPerSample" with type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "sal_uLong" (64 bits, unsigned).
853                             nGreen = GetBits( pMap[ 1 ], ( nx * nSamplesPerPixel + 1 ) * nBitsPerSample, nBitsPerSample );
854                             nBlue = GetBits( pMap[ 2 ], ( nx * nSamplesPerPixel + 2 ) * nBitsPerSample, nBitsPerSample );
855                         }
856                         else
857                         {
858                             nRed = GetBits( pMap[ 0 ], nx * nBitsPerSample, nBitsPerSample );
/filter/source/graphicfilter/itiff/itiff.cxx: 854 in TIFFReader::ConvertScanline(int)()
848                     for (sal_Int32 nx = 0; nx < nImageWidth; ++nx)
849                     {
850                         if ( nPlanes < 3 )
851                         {
852                             nRed = GetBits( pMap[ 0 ], ( nx * nSamplesPerPixel + 0 ) * nBitsPerSample, nBitsPerSample );
853                             nGreen = GetBits( pMap[ 1 ], ( nx * nSamplesPerPixel + 1 ) * nBitsPerSample, nBitsPerSample );
>>>     CID 1403736:    (OVERFLOW_BEFORE_WIDEN)
>>>     Potentially overflowing expression "(nx * this->nSamplesPerPixel + 2U) * this->nBitsPerSample" with type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "sal_uLong" (64 bits, unsigned).
854                             nBlue = GetBits( pMap[ 2 ], ( nx * nSamplesPerPixel + 2 ) * nBitsPerSample, nBitsPerSample );
855                         }
856                         else
857                         {
858                             nRed = GetBits( pMap[ 0 ], nx * nBitsPerSample, nBitsPerSample );
859                             nGreen = GetBits( pMap[ 1 ], nx * nBitsPerSample, nBitsPerSample );
/filter/source/graphicfilter/itiff/itiff.cxx: 877 in TIFFReader::ConvertScanline(int)()
871                     for (sal_Int32 nx = 0; nx < nImageWidth; ++nx)
872                     {
873                         if ( nPlanes < 3 )
874                         {
875                             nRed = GetBits( pMap[ 0 ],( nx * nSamplesPerPixel + 0 ) * nBitsPerSample, nBitsPerSample );
876                             nGreen = GetBits( pMap[ 0 ],( nx * nSamplesPerPixel + 1 ) * nBitsPerSample, nBitsPerSample );
>>>     CID 1403736:    (OVERFLOW_BEFORE_WIDEN)
>>>     Potentially overflowing expression "(nx * this->nSamplesPerPixel + 2U) * this->nBitsPerSample" with type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "sal_uLong" (64 bits, unsigned).
877                             nBlue = GetBits( pMap[ 0 ],( nx * nSamplesPerPixel + 2 ) * nBitsPerSample, nBitsPerSample );
878                         }
879                         else
880                         {
881                             nRed = GetBits( pMap[ 0 ], nx * nBitsPerSample, nBitsPerSample );
882                             nGreen = GetBits( pMap[ 1 ], nx * nBitsPerSample, nBitsPerSample );

** CID 1403735:  Incorrect expression  (MIXED_ENUMS)
/sw/source/uibase/frmdlg/frmmgr.cxx: 250 in SwFlyFrameAttrMgr::ValidateMetrics(SvxSwFrameValidation &, const SwPosition *, bool)()


________________________________________________________________________________________________________
*** CID 1403735:  Incorrect expression  (MIXED_ENUMS)
/sw/source/uibase/frmdlg/frmmgr.cxx: 250 in SwFlyFrameAttrMgr::ValidateMetrics(SvxSwFrameValidation &, const SwPosition *, bool)()
244         }
245     
246         SwRect aBoundRect;
247     
248         // OD 18.09.2003 #i18732# - adjustment for allowing vertical position
249         //      aligned to page for fly frame anchored to paragraph or to character.
>>>     CID 1403735:  Incorrect expression  (MIXED_ENUMS)
>>>     Mixing enum types "RndStdIds" and "com::sun::star::text::TextContentAnchorType" for "eAnchorType".
250         const RndStdIds eAnchorType = static_cast<RndStdIds >(rVal.nAnchorType);
251         const SwFormatFrameSize& rSize = static_cast<const SwFormatFrameSize&>(m_aSet.Get(RES_FRM_SIZE));
252         m_pOwnSh->CalcBoundRect( aBoundRect, eAnchorType,
253                                rVal.nHRelOrient,
254                                rVal.nVRelOrient,
255                                pToCharContentPos,

** CID 1403734:    (MIXED_ENUMS)
/sw/source/ui/frmdlg/wrap.cxx: 425 in SwWrapTabPage::ActivatePage(const SfxItemSet &)()
/sw/source/ui/frmdlg/wrap.cxx: 464 in SwWrapTabPage::ActivatePage(const SfxItemSet &)()


________________________________________________________________________________________________________
*** CID 1403734:    (MIXED_ENUMS)
/sw/source/ui/frmdlg/wrap.cxx: 425 in SwWrapTabPage::ActivatePage(const SfxItemSet &)()
419             m_nOldLowerMargin = static_cast< sal_uInt16 >(rUL.GetLower());
420     
421             // position
422             const SwFormatHoriOrient& rHori = static_cast<const SwFormatHoriOrient&>(rSet.Get(RES_HORI_ORIENT));
423             const SwFormatVertOrient& rVert = static_cast<const SwFormatVertOrient&>(rSet.Get(RES_VERT_ORIENT));
424     
>>>     CID 1403734:    (MIXED_ENUMS)
>>>     Mixing enum types "com::sun::star::text::TextContentAnchorType" and "RndStdIds" for "nAnchorType".
425             aVal.nAnchorType = static_cast< css::text::TextContentAnchorType >(m_nAnchorId);
426             aVal.bAutoHeight = rFrameSize.GetHeightSizeType() == ATT_MIN_SIZE;
427             aVal.bAutoWidth = rFrameSize.GetWidthSizeType() == ATT_MIN_SIZE;
428             aVal.bMirror = rHori.IsPosToggle();
429             // #i18732#
430             aVal.bFollowTextFlow =
/sw/source/ui/frmdlg/wrap.cxx: 464 in SwWrapTabPage::ActivatePage(const SfxItemSet &)()
458             nLeft   = aVal.nHPos - aVal.nMinHPos;
459             nRight  = aVal.nMaxWidth - aVal.nWidth;
460             nTop    = aVal.nVPos - aVal.nMinVPos;
461             nBottom = aVal.nMaxHeight - aVal.nHeight;
462     
463             {
>>>     CID 1403734:    (MIXED_ENUMS)
>>>     Mixing enum types "com::sun::star::text::TextContentAnchorType" and "RndStdIds" for "nAnchorType".
464                 if (aVal.nAnchorType == (css::text::TextContentAnchorType)RndStdIds::FLY_AS_CHAR)
465                 {
466                     nLeft = nRight;
467     
468                     if (aVal.nVPos < 0)
469                     {

** CID 1403733:  Integer handling issues  (OVERFLOW_BEFORE_WIDEN)
/filter/source/graphicfilter/itiff/itiff.cxx: 1003 in TIFFReader::ConvertScanline(int)()


________________________________________________________________________________________________________
*** CID 1403733:  Integer handling issues  (OVERFLOW_BEFORE_WIDEN)
/filter/source/graphicfilter/itiff/itiff.cxx: 1003 in TIFFReader::ConvertScanline(int)()
997                     case 4 :
998                     case 3 :
999                     case 2 :
1000                     {
1001                         for (sal_Int32 nx = 0; nx < nImageWidth; ++nx)
1002                         {
>>>     CID 1403733:  Integer handling issues  (OVERFLOW_BEFORE_WIDEN)
>>>     Potentially overflowing expression "nx * this->nBitsPerSample" with type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "sal_uLong" (64 bits, unsigned).
1003                             nVal = ( GetBits( pt, nx * nBitsPerSample, nBitsPerSample ) - nMinSampleValue ) * nMinMax;
1004                             pAcc->SetPixelIndex( nY, nx, static_cast<sal_uInt8>(nVal));
1005                         }
1006                     }
1007                     break;
1008     

** CID 1403732:  Incorrect expression  (MIXED_ENUMS)
/sw/source/uibase/shells/drwbassh.cxx: 775 in SwDrawBaseShell::ValidatePosition(SvxSwFrameValidation &)()


________________________________________________________________________________________________________
*** CID 1403732:  Incorrect expression  (MIXED_ENUMS)
/sw/source/uibase/shells/drwbassh.cxx: 775 in SwDrawBaseShell::ValidatePosition(SvxSwFrameValidation &)()
769         rValidation.nMinWidth =  MINFLY;
770     
771         SwRect aBoundRect;
772     
773         // OD 18.09.2003 #i18732# - adjustment for allowing vertical position
774         //      aligned to page for fly frame anchored to paragraph or to character.
>>>     CID 1403732:  Incorrect expression  (MIXED_ENUMS)
>>>     Mixing enum types "RndStdIds" and "com::sun::star::text::TextContentAnchorType" for "eAnchorType".
775         const RndStdIds eAnchorType = static_cast<RndStdIds >(rValidation.nAnchorType);
776         const SwPosition* pContentPos = nullptr;
777         SdrView*  pSdrView = pSh->GetDrawView();
778         const SdrMarkList& rMarkList = pSdrView->GetMarkedObjectList();
779         if( rMarkList.GetMarkCount() == 1 )
780         {

** CID 1403731:  Null pointer dereferences  (FORWARD_NULL)
/idl/source/objects/slot.cxx: 541 in SvMetaSlot::WriteSlot(const rtl::OString &, unsigned short, const rtl::OString &, SvRefMemberList<SvMetaSlot*> &, unsigned long, SvIdlDataBase &, SvStream &)()


________________________________________________________________________________________________________
*** CID 1403731:  Null pointer dereferences  (FORWARD_NULL)
/idl/source/objects/slot.cxx: 541 in SvMetaSlot::WriteSlot(const rtl::OString &, unsigned short, const rtl::OString &, SvRefMemberList<SvMetaSlot*> &, unsigned long, SvIdlDataBase &, SvStream &)()
535         if ( !pNextSlot )
536         {
537             // There is no slot behind me that has the same ExecMethod.
538             // So I search for the first slot with it (could be myself).
539             i = 0;
540             pEle = rSlotList.empty() ? nullptr : rSlotList[ i ];
>>>     CID 1403731:  Null pointer dereferences  (FORWARD_NULL)
>>>     Assigning: "this->pNextSlot" = "pEle".
541             pNextSlot = pEle;
542             while ( pNextSlot != this )
543             {
544                 if ( pNextSlot->GetStateMethod() == GetStateMethod() )
545                     break;
546                 pEle = ( ++i < rSlotList.size() ) ? rSlotList[ i ] : nullptr;

** CID 440972:  Null pointer dereferences  (REVERSE_INULL)
/sfx2/source/control/bindings.cxx: 344 in SfxBindings::Update_Impl(SfxStateCache *)()


________________________________________________________________________________________________________
*** CID 440972:  Null pointer dereferences  (REVERSE_INULL)
/sfx2/source/control/bindings.cxx: 344 in SfxBindings::Update_Impl(SfxStateCache *)()
338                 bUpdated = true;
339             }
340     
341             delete pSet;
342         }
343     
>>>     CID 440972:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "pCache" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
344         if ( !bUpdated && pCache )
345         {
346             // When pCache == NULL and no SlotServer
347             // (for example due to locked Dispatcher! ),
348             // obviously do not try to update
349             SfxFoundCache_Impl aFoundCache(0, pRealSlot, pCache );


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyd0WJaTyvdmaOvfY46D2qK5rwngD0a-2BgjM-2BGQeM82-2BPMT4P7HOQWa7A-2BKAXVa1IZ8vBybf-2FdoRyM6djNqfDiDjIEQhxLbDxZKTXbDerR-2FKEF5EDLHuL9Xn8IzHSrrhmmpT5kCSaZks9COCQOJ6sM5XcDkyMirendLCTZBmpjR13c-3D

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyd0WJaTyvdmaOvfY46D2qK5H24tiu9-2BJUwoP0VAq6dVy6q97-2BVW7snTMJh7QrUc9bWDaYFNYUJMdhsp6-2FyufgZgH0ZErFzrIx35EKKYAJv0jaYDPvywtK43gvt0S1rDR3wZteGPF2A6XFdTTXxWofNarZNyLSh8gf-2BPKi7g-2B3Vv4-3D



More information about the LibreOffice mailing list