New Defects reported by Coverity Scan for LibreOffice
scan-admin at coverity.com
scan-admin at coverity.com
Sun Apr 16 00:19:12 UTC 2017
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.
10 new defect(s) introduced to LibreOffice found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 10 of 10 defect(s)
** CID 1405158: Incorrect expression (SIZEOF_MISMATCH)
/hwpfilter/source/hpara.cxx: 80 in HWPPara::HWPPara()()
________________________________________________________________________________________________________
*** CID 1405158: Incorrect expression (SIZEOF_MISMATCH)
/hwpfilter/source/hpara.cxx: 80 in HWPPara::HWPPara()()
74 , contain_cshape(0)
75 , etcflag(0)
76 , ctrlflag(0)
77 , pstyno(0)
78 , cshape(new CharShape)
79 {
>>> CID 1405158: Incorrect expression (SIZEOF_MISMATCH)
>>> Passing argument "this->cshape.get()" of type "CharShape *" and argument "16UL" ("sizeof (this->cshape)") to function "memset" is suspicious because a multiple of "sizeof (CharShape) /*40*/" is expected.
80 memset(cshape.get(), 0, sizeof(cshape));
81 memset(&pshape, 0, sizeof(pshape));
82 }
83
84 HWPPara::~HWPPara()
85 {
** CID 1405157: Error handling issues (CHECKED_RETURN)
/sc/qa/unit/ucalc_formula.cxx: 2291 in Test::testFormulaRefUpdateMoveUndo2()()
________________________________________________________________________________________________________
*** CID 1405157: Error handling issues (CHECKED_RETURN)
/sc/qa/unit/ucalc_formula.cxx: 2291 in Test::testFormulaRefUpdateMoveUndo2()()
2285 const ScFormulaCell* pFC = m_pDoc->GetFormulaCell(ScAddress(3,0,0));
2286 CPPUNIT_ASSERT(pFC);
2287 CPPUNIT_ASSERT_EQUAL(SCROW(2), pFC->GetSharedLength());
2288
2289 // Drag A1:B1 into A2:B2 thereby overwriting the old A2:B2 content.
2290 ScDocFunc& rFunc = getDocShell().GetDocFunc();
>>> CID 1405157: Error handling issues (CHECKED_RETURN)
>>> Calling "MoveBlock" without checking return value (as is done elsewhere 20 out of 21 times).
2291 rFunc.MoveBlock(ScRange(0,0,0,1,0,0), ScAddress(0,1,0), true, true, false, true);
2292
2293 std::vector<std::vector<const char*>> aCheckAfter = {
2294 { nullptr, nullptr, "10", "3" },
2295 { "1", "2", "3", "3" },
2296 { "3", nullptr, nullptr, nullptr },
** CID 1399432: Error handling issues (UNCAUGHT_EXCEPT)
/slideshow/source/engine/eventqueue.cxx: 58 in slideshow::internal::EventQueue::~EventQueue()()
________________________________________________________________________________________________________
*** CID 1399432: Error handling issues (UNCAUGHT_EXCEPT)
/slideshow/source/engine/eventqueue.cxx: 58 in slideshow::internal::EventQueue::~EventQueue()()
52 maNextEvents(),
53 maNextNextEvents(),
54 mpTimer( pPresTimer )
55 {
56 }
57
>>> CID 1399432: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
58 EventQueue::~EventQueue()
59 {
60 // add in all that have been added explicitly for this round:
61 EventEntryVector::const_iterator const iEnd( maNextEvents.end() );
62 for ( EventEntryVector::const_iterator iPos( maNextEvents.begin() );
63 iPos != iEnd; ++iPos )
** CID 1399428: Error handling issues (UNCAUGHT_EXCEPT)
/slideshow/source/engine/activitiesqueue.cxx: 48 in slideshow::internal::ActivitiesQueue::~ActivitiesQueue()()
________________________________________________________________________________________________________
*** CID 1399428: Error handling issues (UNCAUGHT_EXCEPT)
/slideshow/source/engine/activitiesqueue.cxx: 48 in slideshow::internal::ActivitiesQueue::~ActivitiesQueue()()
42 maCurrentActivitiesWaiting(),
43 maCurrentActivitiesReinsert(),
44 maDequeuedActivities()
45 {
46 }
47
>>> CID 1399428: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
48 ActivitiesQueue::~ActivitiesQueue()
49 {
50 // dispose all queue entries
51 try
52 {
53 for( const auto& pActivity : maCurrentActivitiesWaiting )
** CID 1399425: Error handling issues (UNCAUGHT_EXCEPT)
/slideshow/source/engine/shapesubset.cxx: 75 in slideshow::internal::ShapeSubset::~ShapeSubset()()
________________________________________________________________________________________________________
*** CID 1399425: Error handling issues (UNCAUGHT_EXCEPT)
/slideshow/source/engine/shapesubset.cxx: 75 in slideshow::internal::ShapeSubset::~ShapeSubset()()
69 mpShapeManager( rShapeManager )
70 {
71 ENSURE_OR_THROW( mpShapeManager,
72 "ShapeSubset::ShapeSubset(): Invalid shape manager" );
73 }
74
>>> CID 1399425: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
75 ShapeSubset::~ShapeSubset()
76 {
77 try
78 {
79 // if not done yet: revoke subset from original
80 disableSubsetShape();
** CID 1399358: Error handling issues (UNCAUGHT_EXCEPT)
/slideshow/source/engine/rehearsetimingsactivity.cxx: 176 in slideshow::internal::RehearseTimingsActivity::~RehearseTimingsActivity()()
________________________________________________________________________________________________________
*** CID 1399358: Error handling issues (UNCAUGHT_EXCEPT)
/slideshow/source/engine/rehearsetimingsactivity.cxx: 176 in slideshow::internal::RehearseTimingsActivity::~RehearseTimingsActivity()()
170 mnYOffset = (metric.GetAscent() + (metric.GetLineHeight() / 20));
171
172 for( const auto& rView : rContext.mrViewContainer )
173 viewAdded( rView );
174 }
175
>>> CID 1399358: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
176 RehearseTimingsActivity::~RehearseTimingsActivity()
177 {
178 try
179 {
180 stop();
181 }
** CID 1399295: Error handling issues (UNCAUGHT_EXCEPT)
/slideshow/source/engine/slide/userpaintoverlay.cxx: 481 in slideshow::internal::UserPaintOverlay::~UserPaintOverlay()()
________________________________________________________________________________________________________
*** CID 1399295: Error handling issues (UNCAUGHT_EXCEPT)
/slideshow/source/engine/slide/userpaintoverlay.cxx: 481 in slideshow::internal::UserPaintOverlay::~UserPaintOverlay()()
475
476 void UserPaintOverlay::drawPolygons()
477 {
478 mpHandler->drawPolygons();
479 }
480
>>> CID 1399295: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
481 UserPaintOverlay::~UserPaintOverlay()
482 {
483 try
484 {
485 mrMultiplexer.removeMouseMoveHandler( mpHandler );
486 mrMultiplexer.removeClickHandler( mpHandler );
** CID 1399289: Error handling issues (UNCAUGHT_EXCEPT)
/slideshow/source/engine/usereventqueue.cxx: 554 in slideshow::internal::UserEventQueue::~UserEventQueue()()
________________________________________________________________________________________________________
*** CID 1399289: Error handling issues (UNCAUGHT_EXCEPT)
/slideshow/source/engine/usereventqueue.cxx: 554 in slideshow::internal::UserEventQueue::~UserEventQueue()()
548 mpMouseEnterHandler(),
549 mpMouseLeaveHandler(),
550 mbAdvanceOnClick( true )
551 {
552 }
553
>>> CID 1399289: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
554 UserEventQueue::~UserEventQueue()
555 {
556 try
557 {
558 // unregister all handlers
559 clear();
** CID 1399209: Error handling issues (UNCAUGHT_EXCEPT)
/sd/source/ui/framework/configuration/ConfigurationUpdater.cxx: 54 in sd::framework::ConfigurationUpdaterLock::~ConfigurationUpdaterLock()()
________________________________________________________________________________________________________
*** CID 1399209: Error handling issues (UNCAUGHT_EXCEPT)
/sd/source/ui/framework/configuration/ConfigurationUpdater.cxx: 54 in sd::framework::ConfigurationUpdaterLock::~ConfigurationUpdaterLock()()
48
49 class ConfigurationUpdaterLock
50 {
51 public:
52 explicit ConfigurationUpdaterLock (ConfigurationUpdater& rUpdater)
53 : mrUpdater(rUpdater) { mrUpdater.LockUpdates(); }
>>> CID 1399209: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "std::length_error" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
54 ~ConfigurationUpdaterLock() { mrUpdater.UnlockUpdates(); }
55 private:
56 ConfigurationUpdater& mrUpdater;
57 };
58
59 //===== ConfigurationUpdater ==================================================
** CID 1399122: Error handling issues (UNCAUGHT_EXCEPT)
/slideshow/source/engine/transitions/shapetransitionfactory.cxx: 107 in slideshow::internal::<unnamed>::ClippingAnimation::~ClippingAnimation()()
________________________________________________________________________________________________________
*** CID 1399122: Error handling issues (UNCAUGHT_EXCEPT)
/slideshow/source/engine/transitions/shapetransitionfactory.cxx: 107 in slideshow::internal::<unnamed>::ClippingAnimation::~ClippingAnimation()()
101 {
102 ENSURE_OR_THROW(
103 rShapeManager,
104 "ClippingAnimation::ClippingAnimation(): Invalid ShapeManager" );
105 }
106
>>> CID 1399122: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
107 ClippingAnimation::~ClippingAnimation()
108 {
109 try
110 {
111 end_();
112 }
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpytuFnncQmhXyPA42-2BbOd6wmrXwR62R5omJfEEyATwim7VBA76nQklnl-2BqeX1uO9BXvGPccq-2BEAxlj-2BS06SpXjPjIh2XyUC4kK5-2BFoc-2BkNfqPKgDhb9ecINtUo21yAkkAYSZ0IwL-2FxYHW4HSUdlkYQJ1zxm-2FWpPb7pwtOCmqmQo78-3D
To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpytuFnncQmhXyPA42-2BbOd6wkzqlUP87mlvPuuzofAMWAB5uHmkOzAE8VecJwSuJd1np9BNVkk9XDj9EJSaiEKLpGkWi-2FMcfMFvsYcxew8AP3l6TseEkx61Utgvf-2B8wRa15c-2Bqr2yYjBDOdyt0-2BcPnLuHzd9iH964V3W-2Fcko7bwqUY-3D
More information about the LibreOffice
mailing list