Removal of extra function data from sc/source/ui/src/scfuncs/src

[Winfried Donkers]

Hi Caolán,

I finally managed to merge my patch, I missed your commit c7aa8e42d3dfd089efa948b776f915e5479b5463 because I searched in gerrit for your recent commits...

IMHO that last commit necessitates a clear warning/comment in the code appropriate wiki or something about the order of the items as it is -since commit  c7aa8e42d3dfd089efa948b776f915e5479b5463 imperative that the correct order is maintained.
I also have difficulty in 'translating' the explanatory comment in sc/source/core/data/funcdesc.cxx, at the top of the constructor for ScFunctionList. The '16-bit value' seems to address the second item of struct ScFunctionDescCore. It looks as if explanation of the first item is missing, plus possibly a message that this comment describes the struct ScFunctionDescCore.

Winfried

________________________________________
Van: LibreOffice [libreoffice-bounces at lists.freedesktop.org] namens Winfried Donkers [winfried.libreoffice at gmail.com]
Verzonden: zaterdag 18 februari 2017 9:51
Aan: libreoffice at lists.freedesktop.org; caloanm at redhat.com
Onderwerp: Removal of extra function data from sc/source/ui/src/scfuncs/src

Hi Caloán,


I encountered a merge problem with one of my patches and so found out
about your changes in sc/source/ui/src/scfuncs/src,  commits
b127134103e0fcf8b415f53eebed0b5180d782e3 and
d698f823c31583cd36dad594d585849dbccbbb4a.

I probably missed any messages you sent out about this change and I have
some questions about the change, as I sometimes try to add and improve
Calc functions.

The comment in the top of sc/source/ui/src/scfuncs.src says "[...] In
this sub resource, with index 1 the description of the function is
given [...]". Do you mean index 0, the first element?

The extra function data now is in sc/source/core/data/funcdesc.cxx,
class ScFunctionList.

Are there other files/classes/functions/etc. that need attention when
adding new Calc functions that I should know of?


Don't get me wrong, the change promises to be a nice improvement, it's
just that I temporarily lost my way and the old
https://wiki.openoffice.org/wiki/Calc/Implementation/Spreadsheet_Functions
(I still haven't found the LibreOffice wiki on this) is really obsolete
by now.

Winfried
_______________________________________________
LibreOffice mailing list
LibreOffice at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice