New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
13 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1398371:  Incorrect expression  (USELESS_CALL)
/basegfx/test/basegfx2d.cxx: 1223 in basegfx2d::bcolor::ciexyzTest()()


________________________________________________________________________________________________________
*** CID 1398371:  Incorrect expression  (USELESS_CALL)
/basegfx/test/basegfx2d.cxx: 1223 in basegfx2d::bcolor::ciexyzTest()()
1217             tools::rgb2ciexyz(maBlack);
1218             tools::rgb2ciexyz(maRed);
1219             tools::rgb2ciexyz(maGreen);
1220             tools::rgb2ciexyz(maBlue);
1221             tools::rgb2ciexyz(maYellow);
1222             tools::rgb2ciexyz(maMagenta);
>>>     CID 1398371:  Incorrect expression  (USELESS_CALL)
>>>     Calling "basegfx::tools::rgb2ciexyz(this->maCyan)" is only useful for its return value, which is ignored.
1223             tools::rgb2ciexyz(maCyan);
1224         }
1225     
1226         // Change the following lines only, if you add, remove or rename
1227         // member functions of the current class,
1228         // because these macros are need by auto register mechanism.

** CID 1398370:  Memory - corruptions  (OVERRUN)
/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx: 386 in TiledRowColumnBar::docConfigureEvent(_GtkWidget *, _GdkEventConfigure *, void *)()


________________________________________________________________________________________________________
*** CID 1398370:  Memory - corruptions  (OVERRUN)
/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx: 386 in TiledRowColumnBar::docConfigureEvent(_GtkWidget *, _GdkEventConfigure *, void *)()
380                 "\"HorizontalAlignment\":{"
381                 "\"type\":\"unsigned short\", "
382                 "\"value\":\"%d\""
383                 "}"
384                 "}";
385     
>>>     CID 1398370:  Memory - corruptions  (OVERRUN)
>>>     Allocating insufficient memory for the terminating null of the string.
386             char unoHorAlignArgsFormatted[strlen(unoHorAlignArgs)];
387             snprintf(unoHorAlignArgsFormatted, sizeof(unoHorAlignArgsFormatted), unoHorAlignArgs, 1);
388             lcl_registerToolItem(rWindow, rWindow.m_pLeftpara, ".uno:HorizontalAlignment", std::string(unoHorAlignArgsFormatted));
389             snprintf(unoHorAlignArgsFormatted, sizeof(unoHorAlignArgsFormatted), unoHorAlignArgs, 2);
390             lcl_registerToolItem(rWindow, rWindow.m_pCenterpara, ".uno:HorizontalAlignment", std::string(unoHorAlignArgsFormatted));
391             snprintf(unoHorAlignArgsFormatted, sizeof(unoHorAlignArgsFormatted), unoHorAlignArgs, 3);

** CID 1398369:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/core/draw/dcontact.cxx: 589 in SwFlyDrawContact::SwClientNotify(const SwModify &, const SfxHint &)()


________________________________________________________________________________________________________
*** CID 1398369:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/core/draw/dcontact.cxx: 589 in SwFlyDrawContact::SwClientNotify(const SwModify &, const SfxHint &)()
583         SwContact::SwClientNotify(rMod, rHint);
584         if(auto pGetZOrdnerHint = dynamic_cast<const sw::GetZOrderHint*>(&rHint))
585         {
586             // #i11176#
587             // This also needs to work when no layout exists. Thus, for
588             // FlyFrames an alternative method is used now in that case.
>>>     CID 1398369:  Null pointer dereferences  (FORWARD_NULL)
>>>     Assigning: "pFormat" = "dynamic_cast <SwFrameFormat const *>(rMod)".
589             auto pFormat(dynamic_cast<const SwFrameFormat*>(&rMod));
590             if(pFormat->Which() == RES_FLYFRMFMT && !pFormat->getIDocumentLayoutAccess().GetCurrentViewShell())
591                 pGetZOrdnerHint->m_rnZOrder = GetMaster()->GetOrdNum();
592         }
593     }
594     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy8KKgQJetE0bvSegy2wEPKZOpuitNhTzMIun-2BLWgzpRkQ2zgqBpc2AvpeJSTeh-2Fjl-2FYy9avV7ZbFQ1kQllmVEAIO0RmdIfhEB6PVvF1gJQMN3VAWF92mpCIav5grL-2BoaG4g0hOUk1kWuhZFHxMEikAU-2BBx1E-2FOboBHL4lGe2rzyY-3D

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy8KKgQJetE0bvSegy2wEPKS0fTbzsYtmyJktpyCKYUjt6xtldF8fBtdksEAJWrOrflZao1doIXqd-2BbQzNtrf64vnhQKT4QxLfpNU-2BcriyaiqJsjWwdQ6bEkyKPNiMXom31Loo3iNd9zP6BP38iMHmkVPKkhm95Z-2FMkrlGuJhhPtA-3D