New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1412762:  Integer handling issues  (SIGN_EXTENSION)
/sw/source/core/doc/docsort.cxx: 944 in FlatFndBox::GetItemSet(unsigned short, unsigned short) const()


________________________________________________________________________________________________________
*** CID 1412762:  Integer handling issues  (SIGN_EXTENSION)
/sw/source/core/doc/docsort.cxx: 944 in FlatFndBox::GetItemSet(unsigned short, unsigned short) const()
938     }
939     
940     const SfxItemSet* FlatFndBox::GetItemSet(sal_uInt16 n_Col, sal_uInt16 n_Row) const
941     {
942         OSL_ENSURE( ppItemSets.empty() || ( n_Col < nCols && n_Row < nRows), "invalid array access");
943     
>>>     CID 1412762:  Integer handling issues  (SIGN_EXTENSION)
>>>     Suspicious implicit sign extension: "this->nCols" with type "sal_uInt16" (16 bits, unsigned) is promoted in "n_Row * this->nCols + n_Col" to type "int" (32 bits, signed), then sign-extended to type "unsigned long" (64 bits, unsigned).  If "n_Row * this->nCols + n_Col" is greater than 0x7FFFFFFF, the upper bits of the result will all be 1.
944         return !ppItemSets.empty() ? ppItemSets[n_Row * nCols + n_Col].get() : nullptr;
945     }
946     
947     sal_uInt16 SwMovedBoxes::GetPos(const SwTableBox* pTableBox) const
948     {
949         std::vector<const SwTableBox*>::const_iterator it = std::find(mBoxes.begin(), mBoxes.end(), pTableBox);
950         return it == mBoxes.end() ? USHRT_MAX : it - mBoxes.begin();
951     }
952     

** CID 1412761:  Integer handling issues  (SIGN_EXTENSION)
/sw/source/core/doc/docsort.cxx: 944 in FlatFndBox::GetItemSet(unsigned short, unsigned short) const()


________________________________________________________________________________________________________
*** CID 1412761:  Integer handling issues  (SIGN_EXTENSION)
/sw/source/core/doc/docsort.cxx: 944 in FlatFndBox::GetItemSet(unsigned short, unsigned short) const()
938     }
939     
940     const SfxItemSet* FlatFndBox::GetItemSet(sal_uInt16 n_Col, sal_uInt16 n_Row) const
941     {
942         OSL_ENSURE( ppItemSets.empty() || ( n_Col < nCols && n_Row < nRows), "invalid array access");
943     
>>>     CID 1412761:  Integer handling issues  (SIGN_EXTENSION)
>>>     Suspicious implicit sign extension: "n_Row" with type "sal_uInt16" (16 bits, unsigned) is promoted in "n_Row * this->nCols + n_Col" to type "int" (32 bits, signed), then sign-extended to type "unsigned long" (64 bits, unsigned).  If "n_Row * this->nCols + n_Col" is greater than 0x7FFFFFFF, the upper bits of the result will all be 1.
944         return !ppItemSets.empty() ? ppItemSets[n_Row * nCols + n_Col].get() : nullptr;
945     }
946     
947     sal_uInt16 SwMovedBoxes::GetPos(const SwTableBox* pTableBox) const
948     {
949         std::vector<const SwTableBox*>::const_iterator it = std::find(mBoxes.begin(), mBoxes.end(), pTableBox);
950         return it == mBoxes.end() ? USHRT_MAX : it - mBoxes.begin();
951     }
952     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyAOVJA5HwneUgrwoAsm-2FAxxIXj1CwTjMAZKOF-2F5jxAjJtalgLfGawDcv69jgwJEYC5T64H4tjS-2BXv-2Be6rqpV7EpMPUASqgSA0wvwVilD1O1fXsA5AKM3fwhNoX7S9fZ2p0qBtsGmyz-2F-2BEHyypwEcKw9QFHw0m4gQQaYQO5EFyDAg-3D

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyAOVJA5HwneUgrwoAsm-2FAx5O7EtYraYCnFRbnrbk2VytYBDeCi5QRg5ayZK76bAGD9he8wwaI6lbM8gI40SnZc7OtgeNGOVh7btsdkWJj8pMmNQaFxBLsZPdOUXoUTrdkGIHjJf4aNzSJaIM4pwlTypQNGlBuMemsrUTDGd-2FDWD8-3D