New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
7 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1413007:    (ARRAY_VS_SINGLETON)
/sc/source/filter/excel/xepivotxml.cxx: 652 in XclExpXmlPivotTables::SavePivotTableXml(XclExpXmlStream &, const ScDPObject &, int)()
/sc/source/filter/excel/xepivotxml.cxx: 662 in XclExpXmlPivotTables::SavePivotTableXml(XclExpXmlStream &, const ScDPObject &, int)()


________________________________________________________________________________________________________
*** CID 1413007:    (ARRAY_VS_SINGLETON)
/sc/source/filter/excel/xepivotxml.cxx: 652 in XclExpXmlPivotTables::SavePivotTableXml(XclExpXmlStream &, const ScDPObject &, int)()
646                     aMemberSequence.push_back(it - rCacheFieldItems.begin());
647                 }
648             }
649     
650             auto pAttList = sax_fastparser::FastSerializerHelper::createAttrList();
651             pAttList->add(XML_axis, toOOXMLAxisType(eOrient));
>>>     CID 1413007:    (ARRAY_VS_SINGLETON)
>>>     Taking address with "false ? "1" : "0"" yields a singleton pointer.
652             pAttList->add(XML_showAll, BS(false));
653     
654             long nSubTotalCount = pDim->GetSubTotalsCount();
655             std::vector<OString> aSubtotalSequence;
656             for (long nSubTotal = 0; nSubTotal < nSubTotalCount; ++nSubTotal)
657             {
/sc/source/filter/excel/xepivotxml.cxx: 662 in XclExpXmlPivotTables::SavePivotTableXml(XclExpXmlStream &, const ScDPObject &, int)()
656             for (long nSubTotal = 0; nSubTotal < nSubTotalCount; ++nSubTotal)
657             {
658                 ScGeneralFunction eFunc = pDim->GetSubTotalFunc(nSubTotal);
659                 aSubtotalSequence.push_back(GetSubtotalFuncName(eFunc));
660                 sal_Int32 nAttToken = GetSubtotalAttrToken(eFunc);
661                 if (!pAttList->hasAttribute(nAttToken))
>>>     CID 1413007:    (ARRAY_VS_SINGLETON)
>>>     Taking address with "true ? "1" : "0"" yields a singleton pointer.
662                     pAttList->add(nAttToken, BS(true));
663             }
664     
665             sax_fastparser::XFastAttributeListRef xAttributeList(pAttList);
666             pPivotStrm->startElement(XML_pivotField, xAttributeList);
667     

** CID 1413006:  Incorrect expression  (MIXED_ENUMS)
/sc/source/filter/excel/xepivotxml.cxx: 775 in XclExpXmlPivotTables::SavePivotTableXml(XclExpXmlStream &, const ScDPObject &, int)()


________________________________________________________________________________________________________
*** CID 1413006:  Incorrect expression  (MIXED_ENUMS)
/sc/source/filter/excel/xepivotxml.cxx: 775 in XclExpXmlPivotTables::SavePivotTableXml(XclExpXmlStream &, const ScDPObject &, int)()
769                 pPivotStrm->write("<")->writeId(XML_dataField);
770                 if (pName)
771                     rStrm.WriteAttributes(XML_name, XclXmlUtils::ToOString(*pName), FSEND);
772     
773                 rStrm.WriteAttributes(XML_fld, OString::number(nDimIdx).getStr(), FSEND);
774     
>>>     CID 1413006:  Incorrect expression  (MIXED_ENUMS)
>>>     Mixing enum types "com::sun::star::sheet::GeneralFunction" and "ScGeneralFunction" for "eFunc".
775                 sheet::GeneralFunction eFunc = static_cast<sheet::GeneralFunction>(rDim.GetFunction());
776                 const char* pSubtotal = toOOXMLSubtotalType(eFunc);
777                 if (pSubtotal)
778                     rStrm.WriteAttributes(XML_subtotal, pSubtotal, FSEND);
779     
780                 pPivotStrm->write("/>");


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyVvEdavgK2vl2b-2Ft9HuG3XbRgnzdhH5wI8fqdRJNc-2FZY-2FAEBxEgfS6mVW9O3KUAgTENEzUWFJopJvjG7UH35QnagH-2B94JFa55tM5yE8-2BX9XpKYh5oxsLOutnR3EGe8OOOh97Pev8zNPm3JiL-2BoOsgQQdarQ72BE9MLzUqVuDuCVg-3D

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyVvEdavgK2vl2b-2Ft9HuG3XQ1esdro0V829c6bbAtWubJFeF9bGJDz1gz-2B-2Fq4Impq5ctAlGxLXU9onmyXm66CMpO4PAzjkHbrj6HTHMaeZ6kj1zuCBaCNdt7-2Bc5wJbwcDROxplcasWb8tJGQoc8T5f9Cb7N7hU2BHToVX8yaans34-3D