Unuseful SfxObjectFactory::GetFactoryURL() in SfxViewFrame::LoadViewIntoFrame_Impl, any clue?

Matteo Casalin matteo.casalin at libreoffice.org
Mon Mar 20 15:30:21 UTC 2017


On 2017-03-20 14:44, Caolán McNamara wrote:
> On Fri, 2017-03-17 at 17:39 +0100, Matteo Casalin wrote:
>> 
>> 3. Commit 
>> https://cgit.freedesktop.org/libreoffice/core/commit/?id=a8f1ad65612c
>> 0e54969cabc541b183062ae3d905 
>> 
>> My guess is that the "if" in the code under consideration can be
>> removed.
> 
> Yeah, its clearly meaningless so might as well remove it. No idea what
> the original intent there was, but its all quite a long time ago now so
> safest is to just remove the code that does nothing.

Great, I will remove that lines.
Thanks for the feedback!

Kind regards
Matteo


More information about the LibreOffice mailing list