New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
23 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1408971:    (MIXED_ENUMS)
/sal/osl/unx/file_url.cxx: 604 in osl_getAbsoluteFileURL()
/sal/osl/unx/file_url.cxx: 616 in osl_getAbsoluteFileURL()
/sal/osl/unx/file_url.cxx: 619 in osl_getAbsoluteFileURL()


________________________________________________________________________________________________________
*** CID 1408971:    (MIXED_ENUMS)
/sal/osl/unx/file_url.cxx: 604 in osl_getAbsoluteFileURL()
598         if (rc != FileBase::E_None)
599             return oslFileError(rc);
600     
601         if (systemPathIsRelativePath(unresolved_path))
602         {
603             rtl::OUString base_path;
>>>     CID 1408971:    (MIXED_ENUMS)
>>>     Mixing enum types "osl::FileBase::RC" and "oslFileError" for "rc".
604             rc = (FileBase::RC) osl_getSystemPathFromFileURL_Ex(ustrBaseDirURL, &base_path.pData);
605     
606             if (rc != FileBase::E_None)
607                 return oslFileError(rc);
608     
609             rtl::OUString abs_path;
/sal/osl/unx/file_url.cxx: 616 in osl_getAbsoluteFileURL()
610             systemPathMakeAbsolutePath(base_path, unresolved_path, abs_path);
611     
612             unresolved_path = abs_path;
613         }
614     
615         rtl::OUString resolved_path;
>>>     CID 1408971:    (MIXED_ENUMS)
>>>     Mixing enum types "osl::FileBase::RC" and "oslFileError" for "rc".
616         rc = (FileBase::RC) osl_getAbsoluteFileURL_impl_(unresolved_path, resolved_path);
617         if (rc == FileBase::E_None)
618         {
619             rc = (FileBase::RC) osl_getFileURLFromSystemPath(resolved_path.pData, pustrAbsoluteURL);
620             OSL_ASSERT(FileBase::E_None == rc);
621         }
/sal/osl/unx/file_url.cxx: 619 in osl_getAbsoluteFileURL()
613         }
614     
615         rtl::OUString resolved_path;
616         rc = (FileBase::RC) osl_getAbsoluteFileURL_impl_(unresolved_path, resolved_path);
617         if (rc == FileBase::E_None)
618         {
>>>     CID 1408971:    (MIXED_ENUMS)
>>>     Mixing enum types "osl::FileBase::RC" and "oslFileError" for "rc".
619             rc = (FileBase::RC) osl_getFileURLFromSystemPath(resolved_path.pData, pustrAbsoluteURL);
620             OSL_ASSERT(FileBase::E_None == rc);
621         }
622     
623         return oslFileError(rc);
624     }

** CID 1408970:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/sw/source/core/text/possiz.hxx: 26 in ()


________________________________________________________________________________________________________
*** CID 1408970:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/sw/source/core/text/possiz.hxx: 26 in ()
20     #define INCLUDED_SW_SOURCE_CORE_TEXT_POSSIZ_HXX
21     
22     #include <tools/gen.hxx>
23     #include <sal/types.h>
24     
25     // Compared to the SV sizes SwPosSize is always positive
>>>     CID 1408970:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "SwPosSize" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
26     class SwPosSize
27     {
28         sal_uInt16 nWidth;
29         sal_uInt16 nHeight;
30     public:
31         SwPosSize( const sal_uInt16 nW = 0, const sal_uInt16 nH = 0 )


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy80U-2F9UN6jSSCfm91gsWPDHKRIagSjF2poKxsdPG-2BggKs474qKBVcN-2B9fScTJQAEqDGm4KhpY-2Bo7fwKW-2Fxsm8HueAL3YT5q-2F3H5OGNGdjWPgccp0eFBjEflS7ccuHRhh843rwNhp2kzb6d2s8i8T-2Fnyt1KtLx2FOdgWyM3galBjk-3D

To manage Coverity Scan email notifications for "libreoffice at lists.freedesktop.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy80U-2F9UN6jSSCfm91gsWPDI4mjAn68bgreXFPJXXwym1IaXBf2tSujgNf3DtOS-2BbcwBGT2mVsj33MTtei2Owv0vDP-2Fm57AaeEmZeIPgc1HuE0zLnsr6unpMqfyfdtJuDMYisgQJHladMCtlsbERPqqA2WmdRwUObQZqoyG5SulH0-3D